Several bugs related to sinon about karma-chai-plugins HOT 8 CLOSED

You don't have to include sinon separately, sinon-chai should be exactly enough.

from karma-chai-plugins.

@princed so we have to npm i --save-dev sinon-chai ? Or are you saying karma-chai-plugins should suffice ? (which is not, hence this report)

from karma-chai-plugins.

No, you haven't.
I meant you shouldn't include sinon in frameworks list in config as well: [... 'mocha', 'chai', 'sinon-chai']
Sorry for me being confusing.

from karma-chai-plugins.

Ahh ! I'll try...

from karma-chai-plugins.

Tricky ! I think I got it. In my code, I'm doing const expect = require('chai').expect in order to have a typed expect (for typescript reasons).

However, it appear that doing so returns me another, non sinon-enabled instance of "expect" which is not the same as the global one, which is correctly sinon-enabled. Blame the webpack ?

from karma-chai-plugins.

All that karma plugins stuff doesn't really connect with webpack.
But I have some idea for you: you could use externals option somewhere in your webpack config for tests to be able to “require” them from global, like:

// webpack-test.config.js
externals: {
    chai: 'var chai'
}

// test.js
import {expect} from 'chai';

from karma-chai-plugins.

Thanks for the help. I ended up not typing sinon :-( Not sure if my coworkers will agree.

Created a PR for warning of what you told me #91

from karma-chai-plugins.

Sinon is rather good. Didn't externals help you?

from karma-chai-plugins.