Git Product home page Git Product logo

Comments (4)

shawnbot avatar shawnbot commented on March 29, 2024

Some notes here after trying out Next.js in #64 and then switching back to using x0 in #65 with examples broken out into individual files:

  1. Next was great up until I tried exporting the site and ran into a bunch of issues with component examples that use Kit's <Details> element. I ended up having to comment those out to get it exporting.
  2. I much prefer the way that Next allows you to customize the HTML template to how x0 does it: Next does it in React, but x0 does it with a function that takes a bunch of props but returns a string (presumably so that you can change the doctype?).
  3. Both x0 and Next.js support filesystem-based routing and exports, but I couldn't get either to work the way I expected/wanted them to. 🤔

from react.

emplums avatar emplums commented on March 29, 2024

Update: I got routing working as we'd like, but even when examples route to /primer-react/components/Box, the permalink still doesn't work ☚ī¸ I suspect it's because x0 doesn't generate static html files for each of the examples, they're all being visually rendered with the js in the bundle, maybe?

from react.

broccolini avatar broccolini commented on March 29, 2024

Did you try this? #84 (comment)

from react.

shawnbot avatar shawnbot commented on March 29, 2024

Hey hey, this works! E.g. https://primer.github.io/primer-react/components/Details 🎉

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.