Comments (5)
Some documentation for figuring out what we need/have
- https://paper.dropbox.com/doc/Merge-Box-Logic-Design-KDClnvokqzoq2NIinhlJd (full UX docs from venetucci)
- Screenshot generated locally using the merge_matrix page https://github.com/github/github/pull/91180
from react.
@jonrohan can you post a link to that image of the merge box matrix you made last week?
from react.
Another visual aspect to consider is the caret that connects the status icon to the actual "box" portion of the merge box:
This caret could be useful in a bunch of other places, including dropdowns, popovers, select menus, and maybe even tooltips? What do we think about a separate component for it that can be styled and positioned in different ways?
from react.
Looks like we might also need a CopyText component (wrapper around Button?) and/or a CodeExample component
from react.
We also need a SelectMenu for the merge button dropdown, but select menu css isn't included in primer/primer yet 😭
from react.
Related Issues (20)
- IconButton is using color `fg.default` instead of `fg.muted` HOT 2
- Simplify custom-element react bindings with util
- PageLayout doesn't extend the sidebar divider when extending the height.
- Deprecate and remove the input `contrast` prop HOT 3
- Disabled inputs look the same as enabled inputs in dark themes
- RelativeTime should render some kind of date in SSR HOT 1
- Dialog: Focus shifts unexpectedly on opening HOT 2
- NavList.Item active state should show up as bold, but doesn't. HOT 2
- Sub-component pattern cause error when used in React Server Components HOT 1
- Get ActionBar axe clean
- Type checking is too slow HOT 3
- Clean up custom element styled class names
- Underline nav: Doesn't work well on the smallest breakpoints HOT 8
- Release Tracking
- Setting `required` to `input` element within `TextInput` HOT 2
- TypeError: CSS.supports is not a function when running Jest tests HOT 1
- Active `NavList.Item` is incorrectly missing bold styling HOT 4
- The theme object inflates bundle size. HOT 1
- Release Tracking
- The `useAnchoredPosition` hook returns generic refs for Element, which always requires a type assertion by the user
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.