Git Product home page Git Product logo

Comments (5)

broccolini avatar broccolini commented on May 23, 2024 1

Thanks for exploring these options @ashygee!

Versions 1 and 4 stand out best contrast-wise so I think worth continuing with those options. Version 1 seems most recognizable with the Primer brand currently because it has the colors that are used in our illustrations. Version 4 stands out really well against different browser backgrounds, however I'm not sure if it's recognizable as a paintbrush or with Primer's paintbrush when outlined since it looses it's detail.

It occured to me that using the paintbrush could be problematic as a favicon because the paintbrush isn't used in all the header illustrations, for example it's not used on https://primer.style/design - and likely won't be used on every site.

I was also thinking we use the GitHub Mark in the header next to "Primer" and this will be our "home" link, and would be good to keep a connection with GitHub. In the new nav explorations I used blue-400 for the mark and heading, and I think we could use that for our favicon (on the style guide we currently use a gradient blue mark):

screen shot 2019-03-02 at 11 09 05 am

The paintbrush head works well for our avatar on GitHub and on things like twitter, particularly as it will be a bit larger in those places and therefore have more room for detail, so you could keep exploring that option for those assets—how would you feel about that?

from primer.style.

ashygee avatar ashygee commented on May 23, 2024

@broccolini that makes sense. I will continue to explore using the paintbrush for avatars then.

I'll put up some mocks with the GitHub mark using blue-400.

from primer.style.

ashygee avatar ashygee commented on May 23, 2024

Here are options using the GitHub mark but styled using a variation from Primer's blue color palette. The values used are blue-600 and blue-400. The original package favicon is set to blue-600 but per @broccolini comments above we may also want to consider consistency between the top navigation for the site and our favicon to uphold branding. For contrast, both values work well except in an instance where the theme such as the Classic Blue theme is being used, at this point blue-400 gets washed out.

--- blue-600 --- --- blue-400 --- --- original ---

screenshot 2019-03-04 12 14 09

screenshot 2019-03-04 12 14 31

screenshot 2019-03-04 12 14 50

screenshot 2019-03-04 12 15 05

screenshot 2019-03-04 12 15 17

screenshot 2019-03-04 12 15 31

from primer.style.

broccolini avatar broccolini commented on May 23, 2024

Thanks for mocking these up @ashygee 💖

I'm inclined to design this for the default styles and incognito mode. I have no idea how common these other themes are (I never use them!) and which browsers you've tested in, but if it works for defaults in our supported browsers then I would prefer to stick with blue-400 since it matches the new header.

(If you share more screenshots, it would be helpful to see the selected tab with the new favicon in too rather than the old one for comparison.)

from primer.style.

shawnbot avatar shawnbot commented on May 23, 2024

Done in #118! ❤️

from primer.style.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.