Make SubdomainNavBar children optional about brand HOT 14 CLOSED

@waynewi - FYI this feature has now shipped in Primer Brand v0.17.1.

E.g.

from brand.

👋 Thanks for bringing this up.

• The GitHub logomark typically goes back to the github.com homepage, indicated by an arrow hover effect. Will this behave more like a document root link now? So if used on resources.github.com, it will go to / and we remove the hover effect?
• The buttons are already optional, so can work for both of your scenario's @stefankp @waynewi

also cc. @ajashams @samoshin @danielguillan for confirmation that we can use the SubdomainNavBar pattern in this way for non-flagship marketing pages.

from brand.

@stefankp

My thinking is back to Github.com. I know the page is technically housed within resources but that is only because it is powered by Contentful at this point in time.

from brand.

This request sounds reasonable to me. I prefer that we stay consistent and continue to route customers to our /home page when they click the GitHub logo. Otherwise, let's use the / Resources header if that's the intention.

from brand.

Just want to make sure but I do not see any CTA buttons on the right hand side and want to ensure that when it's time to build this in Contentful, it will be clear to the Engineer that it's okay to have CTA buttons.

👍 The buttons still work as usual, and are already optional. No extra work needed to make it work.

Here's an example of how it would all work together:

from brand.

For these campaigns and paid landing pages, we want the ability to hide/omit the subdomain name, too. We'd also like the ability to have one or two CTA buttons. This piece is very important. We would like something that looks like this:

from brand.

The GitHub logomark typically goes back to the github.com homepage, indicated by an arrow hover effect. Will this behave more like a document root link now? So if used on resources.github.com, it will go to / and we remove the hover effect?

@waynewi that's for you to decide.

The buttons are already optional

Ah awesome 👌

from brand.

Thanks @ajashams - one last thing, is it okay to show the logomark without adjacent text in the SubdomainNavBar?

We weren't sure if this was an officially supported pattern, as the component will typically display contextual text alongside it separated by a forward slash. E.g.

If it's okay to use the SubdomainNavBar without title text, we would need to do some minor refactoring to React component to remove the slash, but we'll wait on the answer to the question above..

from brand.

@rezrah - As you already know, the / Subdomain text is meant to mirror a breadcrumb and indicate that you're on a subdomain of GitHub. Clicking the logo always leads to the github.com/home, whereas clicking the subdomain title leads to the subdomain home.

That being said, if the goal of this limited SubdomainNavBar is to focus visitors on single CTAs and remove child links, then I think it's okay to remove the adjacent / Subdomain title from the NavBar as well. I leave this last question entirely up to the systems team, but should we call this Nav Bar something entirely different if it's no longer tied to a specific subdomain?

from brand.

Thanks @ajashams! Yes, the goal is to have a somewhat generic and simplified navigation to help meet the requirements.

@rezrah Please let me know what the next steps would be, e.g., if we need to move this into planning and how this stacks against other work inflight.

from brand.

It's in our inbox, so it's scheduled to be discussed at the next planning call on Monday. 👍 We can ship the update to the component next week, or do you need it sooner @waynewi.

from brand.

Thank you! Let's discuss Monday. @rezrah.

from brand.

@waynewi - I've added support for this in #256. It's due to go out in the next release (v0.17.1), but in the meantime you can take a look at the nav bar example in Storybook.

from brand.

Thank you @rezrah! Just want to make sure but I do not see any CTA buttons on the right hand side and want to ensure that when it's time to build this in Contentful, it will be clear to the Engineer that it's okay to have CTA buttons.

from brand.