Git Product home page Git Product logo

Comments (2)

rezrah avatar rezrah commented on May 3, 2024

Yes, for some context the reason we default to h3 is to help enforce content order, whereby River should only ever appear beneath a SectionIntro, which uses a h2. Appreciate in hindsight how limiting this can be, so I would propose that we resolve this by maintaining the default, but forwarding an override.

cc. @danielguillan @ashygee

from brand.

stefankp avatar stefankp commented on May 3, 2024

Thanks for the context. The way I see it we should enforce content order through the templates we build, not the components themselves, otherwise we create dependencies that don't always make sense. Example, SectionIntro doesn't exist yet and might not be required in each context.

To think about it differently, we can offer different "levels" of components with increased control, e.g

  1. Heading and Text basic building blocks to do anything.
  2. River and SectionIntro components consisting of the above, but free to use independently.
  3. RiverSection, a "section component" (words are hard 😄) consisting of the above and enforcing a certain order.

Think Brick (Primitives) -> House (Components) -> Neighborhood (Sections) -> City (Page template).

from brand.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.