Comments (12)
Yeah, there's another bug about that too. I'll look into it.
from prettier.
Thanks! Yeah, comments are pretty buggy right now. I removed a bunch of logic from recast because I need to convert it to my new API, so still need to do that. I think it's very difficult to keep comments exactly where they are, but we'll see what we can do.
I'm going to focus mostly on your first run-through before announcing it next week. It would be great if others began picking up some of the smaller tweaks and opened PRs after that. It may be good to break this one up into individual issues so that's easier.
from prettier.
Should put the arrow function body on the next line instead of breaking it in weird ways
This was because of the last arg grouping. It's an anon function so it lets it break itself. However I think it makes sense to only allow that if it's an arrow function with braces. I fixed this in 892d070
from prettier.
I think I like the arrow function better for type
I'd like more feedback from Flow users... I think I got this logic from recast. I believe it's easy to tweak if we do want this.
from prettier.
Would be nice to make empty body have the } on their own line
I like the empty block :) These are small diffs, do you think little diffs like that will make it a lot harder for you to pitch this?
For things like like this I would like more feedback from the community, but I also want to prioritize helping make this work for you. I think getting it work on nuclide is a strong use case and I'm fine tweaking the defaults to make that work.
from prettier.
Invalid code generated because of trailing comma
Looks like this was already fixed by another commit
from prettier.
I like the empty block :)
Cool, that's good. There aren't many empty blocks in real world anyway :p
from prettier.
Cool, that's good. There aren't many empty blocks in real world anyway :p
I may have just convinced myself that maybe it's better to split them across 2 lines because then it's easier to add code to them... but this can easily be changed later.
from prettier.
Cool, that's good. There aren't many empty blocks in real world anyway :p
I may have just convinced myself that maybe it's better to split them across 2 lines because then it's easier to add code to them... but this can easily be changed later.
} catch (err) {}
should format to
} catch (and_ignore_err) {}
only half joking...
from prettier.
Invalid code generated because of trailing comma
Looks like this was already fixed by another commit
Do you have a link to the commit that fixes this? I'm still seeing it on version 0.0.4
. This code:
const LongVariableName = longMethodName(longParamName, longSecondParamName, () => {});
becomes:
const LongVariableName = longMethodName(longParamName, longSecondParamName, (
,
) =>
{});
Which is invalid as the comma is inside the empty parameter list.
from prettier.
Just sent #133 and #134 for the types that didn't print on babylon parser.
from prettier.
Closing this one, most of those are either done or already have open issues!
from prettier.
Related Issues (20)
- Prettier breaks Markdown alert syntax
- Prettier changes meaning of HTML+JS code when using tags that look like self-closing HOT 3
- Comment in last line of YAML files gets leading newline trimmed HOT 1
- Typescript: Prettier incorrectly breaks up constructor properties from modifiers when there is a decorator and comment before it HOT 1
- [Documentation] Pre-Commit Hook Usage case caveat
- Still the error "Error: Comment "Hello" was not printed. Please report this error!" even though I have added a comment in the Doc. HOT 1
- [JavaScript] Comments between ternary operator formatting result is ugly HOT 2
- Prettier wrong formatting of Angular flow HOT 3
- Markdown undesirable formatting behaviour when new text added to paragraph HOT 2
- Error when file names HOT 4
- Can we have a CLI flag that allows ignoring .gitignore and/or .prettierignore please? HOT 2
- Unstable block comment for implemented interfaces (TypeScript) (moved and non-idempotent)
- Markdown lists with extra indent lead to unstable formatting behavior
- [SCSS] Put unary boolean operator in front of expression when wrapping HOT 3
- Incorrect JavaScript configuration caching behavior
- Omitting a key does not does not work on the Config type
- Bug: functions in MDX are not formatted if there is at least one empty line HOT 2
- cli
- Github Actions for Node.js 14 x MacOS fails HOT 5
- "sanity timeout expired: Interrupted system call" on WSL2.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier.