Comments (15)
Can you provide a minimal code example which shows this difference ?
from prettier-vscode.
The output of Format Document:
export default store => next => action => {
const callAPI = action[CALL_API];
if (typeof callAPI === "undefined") {
return next(action);
}
const { endpoint, types } = callAPI;
if (typeof endpoint !== "string") {
throw new Error("Specify a string endpoint URL.");
}
if (!Array.isArray(types) || types.length !== 3) {
throw new Error("Expected an array of three action types.");
}
if (!types.every(type => typeof type === "string")) {
throw new Error("Expected action types to be strings.");
}
const actionWith = data => {
const finalAction = { ...action, ...data };
delete finalAction[CALL_API];
return finalAction;
};
const [requestType, successType, failureType] = types;
next(actionWith({ type: requestType }));
return callApi(endpoint).then(
response => next(
actionWith({
response,
type: successType
})
),
error => next(
actionWith({
type: failureType,
error: error.message || "Something bad happened"
})
)
);
};
The output of prettier --write
:
export default store =>
next =>
action => {
const callAPI = action[CALL_API];
if (typeof callAPI === "undefined") {
return next(action);
}
const { endpoint, types } = callAPI;
if (typeof endpoint !== "string") {
throw new Error("Specify a string endpoint URL.");
}
if (!Array.isArray(types) || types.length !== 3) {
throw new Error("Expected an array of three action types.");
}
if (!types.every(type => typeof type === "string")) {
throw new Error("Expected action types to be strings.");
}
const actionWith = data => {
const finalAction = { ...action, ...data };
delete finalAction[CALL_API];
return finalAction;
};
const [requestType, successType, failureType] = types;
next(actionWith({ type: requestType }));
return callApi(endpoint).then(
response =>
next(
actionWith({
response,
type: successType
})
),
error =>
next(
actionWith({
type: failureType,
error: error.message || "Something bad happened"
})
)
);
};
Note how in the latter snippet
export default store => next => action => {
becomes splitet on several lines:
export default store =>
next =>
action => {
from prettier-vscode.
On your screenshot, in vscode's settings, the left part shows the default settings. Yours are on the right ;-)
Will watch into this
from prettier-vscode.
@CiGit Yeah, sorry, you are right. There's nothing there related to prettier though...
from prettier-vscode.
Was just to be sure.
I've a minimal reproduction on my side
s =>
a => {
let v;
};
from prettier-vscode.
(s => a => {
let v;
});
is the output of prettier 0.21
The extension is bundled with [email protected]
$ cat extensions/esbenp.prettier-vscode-0.10.1/node_modules/prettier/package.json| grep '"version":'
"version": "0.21.0"
@esbenp You will have to republish npm install
before ;-)
from prettier-vscode.
So how does this work? Will extension update itself every time new version of prettier is released? Are you required to manually republish extension on every prettier release?
from prettier-vscode.
Currently something like that. I don't know if @esbenp has a little script to publish on his side.
We have #39 awaiting to be able to use prettier from the workspace.
from prettier-vscode.
Good news I have just published #39 which should enable VS Code to use the projects Prettier
from prettier-vscode.
https://github.com/esbenp/prettier-vscode/releases/tag/0.11.0
from prettier-vscode.
@dKab please let us know if this resolves your issue :-)
from prettier-vscode.
Do I need to do anything with the extension? I mean uninstall/install in order to get this fix?
from prettier-vscode.
If you go to the extensions pane it should tell you that it has a new version
from prettier-vscode.
@esbenp It works now, thanks!
from prettier-vscode.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from prettier-vscode.
Related Issues (20)
- Running find & replace on files with formatOnSave enabled overwrites files with incorrect content HOT 2
- Wrong .prettierignore file used when using multiple sub folders HOT 1
- Prettier ignores configuration when formatting unsaved files
- Prettier VSCode Not Consistent With CLI HOT 3
- TS configuration does not wrap
- formatting does not work-takes forever on tiny files
- Invalid Version HOT 1
- `esbenp.prettier-vscode` isn't consistent with `prettier` in `package.json` HOT 1
- Prettier breaks Django template HOT 1
- "prettier.configPath" in vscode's settings.json is ignored HOT 2
- `this.prettierModule.resolveConfigFile is not a function` error when formatting HOT 4
- Prettier not working HOT 1
- The vscode extension is inconsistent with the default value of the prettier configuration file
- Inconsistency in line break formatting in Java with Prettier in VS Code
- Ignore `CODEOWNERS` file HOT 1
- semi
- Ability to use/configure Format On Save to work with prettier configs within folders
- How to set the `rangeStart` configuration for the `prettier-vscode` extension in VS Code? HOT 2
- Prettier formatting yaml files even though a different formatter is selected... HOT 2
- Notification of breaking api change with v1.92 release of VS Code HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier-vscode.