Comments (6)
Merged. Thanks!
And I wonder if the long stack traces are necessary? They pollute the output quite a bit.
That's kind of the point though. You can also use debug
instead of trace
. Thanks for the feedback. I added a note about only running it on one :)
Thanks again!
from prettier-eslint.
I added a section in the README that should help you find out what the problem is: debugging
from prettier-eslint.
this shouldn't have happened, let me install eslint and check
from prettier-eslint.
Thank you!!
from prettier-eslint.
I ran it with trace. The inferred eslint options contain
"quotes": Array [
"error",
"backtick",
],
But the options then passed to prettier by prettier-eslint are
"prettierOptions": Object {
"bracketSpacing": false,
"parser": "babylon",
"printWidth": 80,
"semi": false,
"singleQuote": "backtick",
"tabWidth": 2,
"trailingComma": "es5",
"useTabs": false,
},
Since prettier expects a boolean for singleQuote this breaks like the error suggested. I'll quickly see if I can spot where this happens.
from prettier-eslint.
I created this PR #76
Although I can't figure out how to test it in the wild. If I install it from my github branch the binary doesn't seem to pick up the new code.
BTW The trace mode brings my computer to its knees when I use it on a glob pattern matching a bunch or files. Might be worth mentioning that it's better run on a single file. And I wonder if the long stack traces are necessary? They pollute the output quite a bit.
from prettier-eslint.
Related Issues (20)
- how to integrate with prettier vscode extension? no longer has "prettier.eslintIntegration" option HOT 5
- ability to capture (non-fixable) eslint errors/warnings? HOT 5
- Integration with CI/CD (gitlab) HOT 1
- Error: Failed to load plugin '@next/next' declared in 'CLIOptions': The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received '' HOT 2
- Remove `--prettier-last` option because it's out scope HOT 2
- Support for `padded-blocks` corner cases HOT 3
- Error: `reportUnusedDisableDirectives` must be any of "error", "warn", "off", and null HOT 2
- prettier-eslint fails due to an eslint config error; eslint works if called directly. Typescript overrides issue? HOT 1
- Only Prettier (but not ESLint) formatting is applied to `.cjs` files HOT 7
- prettier-eslint installs vue-eslint-parser 8.30, instead of 9.1.0 HOT 3
- `prettier-eslint` command fails due to unknown environment key `jest/globals` HOT 4
- Configuring reportUnusedDisableDirectives to true in .eslintrc will cause prettier-eslint to not work properly. HOT 1
- TypeError: Expected `input` to be a `string`, got `object` HOT 5
- Is this tool still needed? HOT 1
- Shouldn't this be the other way around? "This formats your code via prettier, and then passes the result of that to eslint --fix." HOT 6
- Status of capturing eslint warnings/errors? HOT 1
- feat: support flat config with `FlatESLint` HOT 7
- [meta] a new OpenCollective home for all `prettier` + `eslint` integration tools HOT 6
- How to use it? HOT 1
- prettier-eslint default trailingComma is not the same as Prettier v3 default trailingComma
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier-eslint.