Git Product home page Git Product logo

Comments (6)

kentcdodds avatar kentcdodds commented on May 17, 2024 2

Merged. Thanks!

And I wonder if the long stack traces are necessary? They pollute the output quite a bit.

That's kind of the point though. You can also use debug instead of trace. Thanks for the feedback. I added a note about only running it on one :)

Thanks again!

from prettier-eslint.

kentcdodds avatar kentcdodds commented on May 17, 2024 1

I added a section in the README that should help you find out what the problem is: debugging

from prettier-eslint.

lemon79 avatar lemon79 commented on May 17, 2024

this shouldn't have happened, let me install eslint and check

from prettier-eslint.

lemon79 avatar lemon79 commented on May 17, 2024

Thank you!!

from prettier-eslint.

0x80 avatar 0x80 commented on May 17, 2024

I ran it with trace. The inferred eslint options contain

"quotes": Array [
        "error",
        "backtick",
      ],

But the options then passed to prettier by prettier-eslint are

"prettierOptions": Object {
    "bracketSpacing": false,
    "parser": "babylon",
    "printWidth": 80,
    "semi": false,
    "singleQuote": "backtick",
    "tabWidth": 2,
    "trailingComma": "es5",
    "useTabs": false,
  },

Since prettier expects a boolean for singleQuote this breaks like the error suggested. I'll quickly see if I can spot where this happens.

from prettier-eslint.

0x80 avatar 0x80 commented on May 17, 2024

I created this PR #76

Although I can't figure out how to test it in the wild. If I install it from my github branch the binary doesn't seem to pick up the new code.

BTW The trace mode brings my computer to its knees when I use it on a glob pattern matching a bunch or files. Might be worth mentioning that it's better run on a single file. And I wonder if the long stack traces are necessary? They pollute the output quite a bit.

from prettier-eslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.