Max line length corner case? about prettier-eslint HOT 2 CLOSED

To be clear... The problem is that because you run prettier first, it removes the space between the function name sortPlacesByDistance and the open paren (. Because of this, prettier doesn't do anything more to the function assignment line (normally it would break it down to the next line). Then when you run eslint --fix it adds it because you've configured space-before-function-paren which will add the space back again and now it's breaking the rule. Because eslint isn't capable of auto-fixing that rule, it remains that way.

It's out of scope for this project to fix an issue like that I'm afraid. You'll just have to change the code so it doesn't do that. This is how you could write it:

module.exports = function (x) {
  function sortPlacesByDistance (place_a, place_b) {
    return place_a.distance - place_b.distance;
  };
  sortPlacesByDistance(x);
};

or even:

module.exports = function(x) {
  const sortPlacesByDistance = function sortPlacesByDistance (placeA, placeB) {
    return placeA.distance - placeB.distance;
  };
  sortPlacesByDistance(x);
};

Good luck! Sorry that this is a little too much of an edge case for us to do anything about :-(

from prettier-eslint.

@kentcdodds

this is a little too much of an edge case for us to do anything about

I understand. =)

Thank you.

from prettier-eslint.