Git Product home page Git Product logo

Comments (3)

dannye avatar dannye commented on August 28, 2024

While it is true that it would be better to have a more descriptive name than wd74b, only bit 5 of that byte determines if the player has the Pokedex. This address is more generally a game progress flag, meaning each bit is a flag for a different game event.

In order to clean this up, I am considering changing wram.asm to something like:

wFlags_d74b:: ds 1
[...]
POKEDEX_OWNED EQU 5

This way, code can check if the player has the Pokedex by using:

ld a, [wFlags_d74b]
bit POKEDEX_OWNED, a

from pokered.

yenatch avatar yenatch commented on August 28, 2024

this flag looks like it was enumerated along with a host of others. for example

constants/event_flags.asm

check_flag: macro
    ld a, [wEventFlags + flag_\1 / 8]
    bit flag_\1 % 8, a
endm

flag: macro
    enum flag_\1
endm

__enum__ = 0
    flag 0
    flag 1
    flag 2
    ...
    flag pokedex
    ...
NUM_EVENT_FLAGS equ __enum__

wram.asm

wEventFlags:
    flag_array NUM_EVENT_FLAGS

then

    check_flag pokedex

from pokered.

dannye avatar dannye commented on August 28, 2024

Handled by #107

from pokered.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.