Comments (3)
ping @PrestaShop/tech-council
Could you take a look at that request ?
Thanks !
from prestashop.
Hi @gurkcity, I get your point, but this hook was added mostly for the purpose of adding custom routes. Why do you need to alter these variables?
I think that this should work, no?
public function hookActionAfterLoadRoutes($params) {
// Add or replace any route
$params['dispatcher']->addRoute(
'my_fancy_controller_rule_name', // Route id
'element', // url rule
'my_fancy_controller', // controller
1, // id lang
[], // keywords
['fc' => 'module', 'module' =>'testmodule'], // params
1 // id shop
);
}
from prestashop.
Hi @Hlavtox
thanks for looking into this.
I understand you if you are only interested in changing the routes. But our idea is to have more flexibility for a rewrite module that wants to find the correct controller not by default PS regex but by other way e.g. database query in selected tables. For this reason we must set the controller in this place. There is no other place suitable for this idea for a complete free set of rewrite rules.
from prestashop.
Related Issues (20)
- Add dedicated permission denied template
- Refacto context listeners into EventSubscriber this will allow merging default listeners with related context listener to keep everything in the same class
- Hummingbird HOT 4
- Make ps_imageslider compliant with v9 .htaccess policy for direct PHP calls HOT 1
- Wrong Vat-Display HOT 1
- BO ps_emailsubscription not multistore compliant
- Autoupgrade - Autoupgrade from 8.0.5 to 9.0.0 - Fatal Error with "_PS_PRICE_DISPLAY_PRECISION_" HOT 3
- Handle multi shop context via Symfony session instead of legacy cookie
- Refacto homepage redirection, duplicated code is common between `AdminAuthenticationSuccessHandler` and `LoginController::homepageAction` this could be extracted in a dedicated service
- Move password reset code into dedicated employee CQRS Commands, use form handlers in LoginController to follow the usual convention and add automatic hooks
- Traductions files ignored when symlink HOT 4
- input type "number" is not styled properly HOT 11
- Remove email "Preview" from BO section "Statutes" (because it's not working) HOT 6
- Thumbnail generation on img/tmp (product_mini_xxx) take about 5sec every image slowing down products page in backoffice HOT 1
- ,,Failed to download'' - That's google search console said, when I paste site map. HOT 7
- The addition of a service during the update of a module is not taken into account by PrestaShop v1.7.8.11. HOT 2
- PPV2 Generate x combinations button not visible when there are multiple features values HOT 2
- Call to a member function formatPrice() on null [Error 0] HOT 4
- Product redirect is not stored correctly in DB HOT 3
- Fixed amount cart rule is duplicated after order splitting HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prestashop.