Comments (2)
After looking at this issue with fresh eyes, I think everything is working as expected. The time increase is due to the overhead of calling the Prefect API for each task run, and the order of execution is the same if the @task
decorator is or isn't there. I think it looks concurrent because the Python-only version is so much faster. I'm going to close this, but feel free to reopen or respond if there's something I missed!
from prefect.
Reopening because we've identified that the new engine creates task runs sequentially in async flows. See this example for reproduction:
import asyncio
from prefect import flow, task, get_run_logger
@task
async def waiter(n: int = 60):
get_run_logger().info(f"Waiting for {n} seconds")
await asyncio.sleep(n)
@flow
async def main(n: int = 100):
waiters = [waiter() for _ in range(n)]
await asyncio.gather(*waiters)
if __name__ == "__main__":
asyncio.run(main())
This is caused by the new engine's use of SyncPrefectClient
to send create task run API calls. The resolution of this issue will involve making those calls non-blocking in async contexts.
from prefect.
Related Issues (20)
- Schedules missing in deployment page HOT 2
- Add `get_events_subscriber` to the docs
- Use codespell to catch spelling errors in docs as part of pre-commit
- `sync_compatible` decorator returning coroutines unexpectedly when running a flow HOT 1
- threading problems with `QueueService` subclasses
- GcsBucket from prefect-gcp duplicates the `bucket_folder` when uploading local files to the GCS bucket. HOT 3
- Block image backgrounds dont respect light/dark mode
- prefect_sqlalchemy SyncDriver.POSTGRESQL_PSYCOPG2 returns duplicate results on second fetch_many execution HOT 1
- Allow using `flow` and `flow_run` properties in infra names HOT 1
- Remove task run API calls from `TaskRunEngine`
- Create task runs from task run events
- Last Updated time for Deployment updates to current time when page is refreshed HOT 5
- Logs don't propagate from worker HOT 8
- Tune our SQLite connections
- Misleading parameter validation error when loading flow from entrypoint without deps HOT 1
- Prefect 2: Migrate to AnyIo 4 HOT 1
- test
- Add 3.0 removal warnings to 2.x codebase
- `prefect3.prefect_aws.credentials` raises `PydanticUserError` due to import of `pydantic.v1.SecretStr` which uses depricated `__modify_schema__` HOT 1
- `prefect deploy` doesn't respect arguments passed through custom decorators
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefect.