Git Product home page Git Product logo

Comments (2)

desertaxle avatar desertaxle commented on July 21, 2024

After looking at this issue with fresh eyes, I think everything is working as expected. The time increase is due to the overhead of calling the Prefect API for each task run, and the order of execution is the same if the @task decorator is or isn't there. I think it looks concurrent because the Python-only version is so much faster. I'm going to close this, but feel free to reopen or respond if there's something I missed!

from prefect.

desertaxle avatar desertaxle commented on July 21, 2024

Reopening because we've identified that the new engine creates task runs sequentially in async flows. See this example for reproduction:

import asyncio

from prefect import flow, task, get_run_logger


@task
async def waiter(n: int = 60):
    get_run_logger().info(f"Waiting for {n} seconds")
    await asyncio.sleep(n)


@flow
async def main(n: int = 100):
    waiters = [waiter() for _ in range(n)]
    await asyncio.gather(*waiters)


if __name__ == "__main__":
    asyncio.run(main())

This is caused by the new engine's use of SyncPrefectClient to send create task run API calls. The resolution of this issue will involve making those calls non-blocking in async contexts.

from prefect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.