python-check-mock-methods complains about existing methods in docstring about pygrep-hooks HOT 6 CLOSED

I've also run into a similar case with Mock.assert_any_call.

from pygrep-hooks.

it complains because it's a very simple regex, it probably won't be able to accommodate every case

the reason it detects it is it errors on anything that is missing parentheses (as is common for developers coming from, for example, ruby where parens are optional)

one way you could make this work is to adjust the regex to explicitly allow "Mock" as the target name (probably with a negative lookbehind)

would you like to take a stab at it? it should be pretty easy to add a test here and then adjust the regex here

from pygrep-hooks.

@torfsen ping! would you like to take a stab at this one?

from pygrep-hooks.

@asottile I currently don't have time for it but may come back to it later.

from pygrep-hooks.

In my opinion, it will be easiest to add a new rule for pylint. It is very difficult to know the context using only the regular expression. It would be very useful to know all the grammar and have an AST tree.

from pygrep-hooks.

but... it already works?

from pygrep-hooks.