(MHRise) Specific hook conditionally causing game freeze about reframework HOT 11 CLOSED

Unable to replicate. I'm reworking how the hooks work internally though.

from reframework.

Is it a work in progress change or has it been included in the latest release, nightly or otherwise? I'd be happy to test it again whenever the hook rework is available.

from reframework.

I've pushed my changes for the hooks.

However, I could see this still happening if you're hooking one function, and then calling getSkillData from within the hook, while it's already hooked. Were you doing this previously?

from reframework.

No, not at all. As mentioned, the freeze occurs for me even without any logic within the hook. I'll test it again tomorrow morning with the new changes.

Granted it's not reproducible though, it might be related to the fact that it's part of a pretty massive project, which already contains a ton of different hooks and functions. I doubt there's a correlation, but maybe there's something in that.

I'll tell you how it goes.

EDIT: Oh wait, I suppose you mean first hooking onto a different function which calls getSkillData in addition to having hooked that function. My mind had immediately hopped to accidental recursion into stack overflowing. I suppose there's a chance I've made a combo like that; As I said, it's a huge and diverse project, so it's not unlikely there's something like that in there somewhere.

from reframework.

Seems to work properly with the newest version.

Now, I've had some issues in the past where hooks and such would stop working even through game restarts due to some kind of system instability of sorts (I genuinely have no clue either), and those issues would be solved by system restarts. Seeing as how I was testing this on a different system, I gave it a shot with the old version as well in order to see if it wasn't system specific, and sure enough: it did freeze on this system as well. So, that means the new hook system did in fact fix something, so thanks a lot for looking into it! 🎉

from reframework.

I should mention that these changes have removed the guarantee between pre and post that the entire hook will be locked down across threads. Meaning that saving some of the args to use in post may break now if it's a method called on multiple threads.

I'm still playing around with this and thinking of possible solutions that won't break old scripts that were relying on this guarantee.

from reframework.

Nightly release will have a thread API for those instances where you absolutely need something you can only get in the pre hook but need to use it in the post hook for some reason. Many cases this may not matter, but to be absolutely correct, then use the thread API, like this:

local pawn_t = sdk.find_type_definition("app.Pawn")

sdk.hook(
    pawn_t:get_method("updateMove"),
    function(args)
        local storage = thread.get_hook_storage()
        storage["this"] = sdk.to_managed_object(args[2])
    end,
    function(retval)
        local this = thread.get_hook_storage()["this"]
        print("this: " .. tostring(this:get_type_definition():get_full_name()))
        return retval
    end
)

This is only necessary if the hooked function seems to be getting called very frequently, and from multiple threads.

Docs: https://cursey.github.io/reframework-book/api/thread.html

from reframework.

381c677 should be the final commit that resolves any issues with the new hooking system. Let me know if these new changes still work as intended.

from reframework.

I'll check it as soon as I have time. Thanks for your hard work! I take it this will become a main branch feature at some point?

from reframework.

It already is on master branch. Unless you mean uploaded to Nexus, then sure. I'm pretty busy with working on the C# API and Dragon's Dogma 2 so don't know when that will happen.

from reframework.

Ah, I meant the master branch, but it would also be neat to have it on nexus so that people won't have too much trouble getting their hands on it, but there's no haste. The mod won't be out for at least a few months, so it can wait until you have more time on your hands.

I've also gotten to test things now, and I'm glad to see that the whole hook args thing isn't as breaking as it sounded. I'll still upgrade my old functions to use the new thread storage, but it's nice to see that my old mods likely won't be affected.
Again, thanks for your hard work!

from reframework.