Prawn PNG Issues about prawn HOT 9 CLOSED

one way to fix this is to extend the scope of prawn-fast-png to handle all png settings, not only the alpha channel extraction.

from prawn.

Yes, that would address at least some of these issues. But then maybe prawn-fast-png would need a more general name… prawn-png-improved ?

Anyway, that’s a question for Wojtek, not me. So feel free to contact him if you want to see if he’s interested.

from prawn.

I've fixed this in my png_fixes branch, plus add some new specs

from prawn.

I was thinking about delegating all PNG handling to RMagick. That would probably give compatibility with any PNG format out there. In that case a name change may be appropriate somewhere in the future. I think it shouldn't be too complicated to rewrite prawn/images/png.rb with RMagick. Unfortunately I'm kind of busy currently and I can't pursue this on my own. Probably in May I'll have more time to try this approach.

from prawn.

I'd imagine replacing Prawn::Images::PNG with a RMagick based version shouldn't be too hard. It's not like it does much.

I'm not sure how Greg feels, but I think that'd be great as an optional prawn plugin. I'd be keen to keep mainline prawn pure ruby if possible. I use c extensions in projects, but sometimes it's nice to be able to weight up the various pros and cons.

ie. faster and more format support vs. possible memory issues and reduced platform compatibility.

from prawn.

By 'rewrite prawn/images/png.rb with RMagick' I meant to monkey patch Prawn::Images::PNG though a separate gem, like now prawn-fast-png deals with alpha channel separation performance.

from prawn.

Oh, in that case, sweet! :)

from prawn.

yeah, right on, a RMagick based Prawn PNG is a good workaround for our bottleneck, but should be done as an extension gem.

Let us know when you have something.

from prawn.

Only unfilter PNG files after we check for compatible types (Closed by 1f6b2fe)

from prawn.