rounded_rectangle about prawn HOT 9 CLOSED

Here is a page that describes several implementations of rounded rectangles for cairo which is a vector library with primitives like pdf

http://cairographics.org/cookbook/roundedrectangles/

from prawn.

Definitely will accept a patch for this, but it needs to be on a fork with tests and examples

from prawn.

Definitely will accept a patch for this, but it needs to be on a fork with tests and examples

Question about this:
When I was making my star shape the other day, I wondered how one would write specs for it. The spec for, as an example, ellipse_at in the Prawn spec suite does test that the API hasn't changed, and that the pointer is back at the center of the ellipse, but it doesn't really test that an ellipse has been drawn, just the last point.

I guess one could create an example, render it, go into the resulting PDF and extract the generated points, and then create a regression test spec.

Do you have guidance on this, Greg?

Thank You,

Daniel

from prawn.

Yeah, good point. Just write some nice examples, and make sure that the API gets tested, and that if we're moving the pointer, it goes to the right place.

from prawn.

Not sure where jontebol got to but I went ahead as suggested by Greg (http://groups.google.com/group/prawn-ruby/browse_frm/thread/791dc2cb72a6ee0f) and took Salamandra's code and fixed it so that it will fill_and_stroke: http://github.com/jonsgreen/prawn/commit/059e035e55a3334d19345db0711a130aae39adeb. My spec is a bit contrived but at least it exercises the code.

from prawn.

I started, but then I had to focus on other things. I was still planning to do this though, possibly within a month or 2, but if you've fixed it already, that's great. :)

from prawn.

Sweet, we'll pull this in for 0.8, then.

from prawn.

I have made an improvement by implementing rounded_polygon making rounded_rectangle just a subset example (http://github.com/jonsgreen/prawn/commit/0b55e7da57c0f5da07fedf138ad197ca58072e6d) I did not add any specs for this method so far relying on the rounded_rectangle spec to exercise the polygon code. Let me know how I might improve the spec coverage for this feature if it is accepted. There is also a clever little pentagram in the rounded_polygon example.

from prawn.

Merged, thank you.

from prawn.