Comments (8)
I think this probably has to start with osu!web returning an actual error message for when the beatmap isn't found. @ppy/team-web
from osu.
Status code 404 is returned when the beatmap isn't found...
from osu.
Doesn't it seem weird that we have to handle 404s in a very specific way for this one scenario? What if a legitimate 404 actually occurs, like the endpoint becomes inaccessible (for any number of reasons), and we miss it because in that very specific scenario we aren't displaying an error message here?
So there's the question of how should we handle this particular case. In the past we've silently ignored this specific case because it would be too verbose to tell the player that the beatmap doesn't exist online. Curious what @peppy thinks of this.
from osu.
What if a legitimate 404 actually occurs, like the endpoint becomes inaccessible (for any number of reasons), and we miss it because in that very specific scenario we aren't displaying an error message here?
I think this is a reach, 404 is a legitimate response when a resource isn't found in REST. I'm not sure we should be worried about "false positives" that could technically happen if nginx eats dirt or something and the entirety of the endpoint is not there anymore.
from osu.
well, osu-web can return a generic error message ("specified beatmap difficulty (123) couldn't be found"). Currently, most/all requests on missing object return json with null
error field.
from osu.
if nginx eats dirt or something
What about if a change in multiplayer happens that results in us not passing the playlist or room to the API, meaning the playlist or room isn't found? My point is, a 404 is a generic catch all term for any resource. It's not specific to a beatmap not being found, and imo we shouldn't treat it that way.
Or what, we add a specific case for multiplayer where it actually does show NotFound
because it's actually an error, but we're expecting that to not be an error in solo?
from osu.
It's not specific to a beatmap not being found, and imo we shouldn't treat it that way.
Ok yeah that's fair.
from osu.
I'll add the message I mentioned above but that said, I'm not sure if client should show the generic error message in this case either...
from osu.
Related Issues (20)
- Incorrect slider stacking on specific beatmap HOT 4
- Hitsounds are not correctly aligned with the song on non-1x speed rate
- Lowering the tone of a song in the editor
- Unable to launch 2024.412.0 appimage HOT 4
- Discord rich presence causes game crash when joining multiplayer lobby on macOS
- Selecting mod causes song select re-fliter HOT 3
- Crash and graphical artifacts when entering gameplay on Vulkan(deferred) HOT 1
- Vulkan renderer fails to initialise on Linux HOT 1
- Certain float settings are saved weirdly in the editor HOT 10
- Freeze but cursor move (on multiplayer match?) HOT 3
- Leaderboard cannot be hidden in multiplayer HOT 4
- First-run setup opening everytime i open osu lazer? HOT 2
- Game Restarts Itself Even After Changing the Renderer to Its Initial Value HOT 2
- Memory leak when converting scores in spectator mode
- Exporting a replay when viewing the score from within an online leaderboard causes it to be corrupted
- In tablet mode Left mouse button releasing upon getting input from tablet. HOT 1
- `ScoreInfo.Passed` should be deprecated in favour of F rank HOT 3
- Exporting lazer scores loses indication of whether it is failed HOT 1
- Stable scores that award pp show "performance points are not granted for this score" because of classic mod
- Buggy behaviour when closing beatmap browser as a preview song is loading HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osu.