Comments (8)
Issue-Label Bot is automatically applying the label feature_request
to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.
from secretmanagement.
Changing the required extension vault name would be a breaking change, and all vault authors would have to update their vault modules, and I would prefer not to allow alternative naming conventions as it seems unnecessary. The current naming convention is enough to disambiguate different extension vault modules, and calls to extension vault functions. So I am marking this as 'wont' fix' for now.
from secretmanagement.
Thanks @JustinGrote do you know of any other module patterns that use .Extension?
We like the idea of having the submodule name in the PSData but arent sure if it is worth making the breaking change for...would love more input from the community on this one--thanks!
from secretmanagement.
@SydneyhSmith not currently so it's not a breaking change but it doesn't hurt to be explicit. The PSData can be an optional addition and SecretManagement can look both places so it wouldn't be breaking to add it.
from secretmanagement.
@PaulHigin @SydneyhSmith @joeyaiello @SteveL-MSFT my only thought is that there may need to be a wider standard/recommendation on this. For instance, there are now going to be PSReadline intellisense extensions. What's that going to be? If I make a powershell module and I want to implement all of this, am I going to have a bunch of seemingly arbitrary folders in my source to implement them or are they going to have a nice nomenclature, e.g. MyModule.SecretManagementExtension
and MyModule.PSReadlineExtension
?
from secretmanagement.
I think moving forward the extension directory name can be defined in the parent module manifest, private data field (as suggested by @SteveL-MSFT). Any new extension module can use that and avoid the current SecretManagment hard coded naming convention. In fact, SecretManagement can move to this model at any time and still be backward compatible to the hard coded naming.
But at this time, I don't see any problem with the current naming scheme for SecretManagement.
from secretmanagement.
private data field (as suggested by @SteveL-MSFT)
😕
from secretmanagement.
Sorry, I forgot you suggested it! But I agree that is a better way to define the extension name.
from secretmanagement.
Related Issues (20)
- Test-SecretVault cmdlet failing with "Assembly with same name is already loaded" HOT 2
- Documentation is just the stock help template. HOT 1
- Verbose output for Get-Secret is incorrect
- Get-Secret is Overzealous in SecureString Generation When Returning Hashtables. HOT 8
- CredManStore does not appear to work in a PowerShell remote session
- Provide Password/Passphrase Generator
- Inconsistent behaviour of -Verbose when encountering Throw HOT 1
- While developing an extension: Prevent session restart for reloading the module HOT 2
- AdditionalParameters is providing a CaseSensitive HashTable HOT 2
- Random unexpected secrets appear in vault HOT 1
- Get-SecretInfo : Exception calling "GetInstance" with "0" argument(s): "Padding is invalid and cannot be removed."
- Publish the library as netstandard20
- Secret object type for deeper integration HOT 2
- Binary extension module not returning objects?
- Add ArgumentCompleters
- Creating a Secret HOT 1
- Make secret vaults not require use of PowerShell HOT 1
- Get-SecretInfo: The specified module '...\Microsoft.PowerShell.SecretStore' was not loaded because no valid module file was found in any module directory. HOT 4
- Set/Add/New secret should be separate cmdlets HOT 1
- Set-Secret asks for password to unlock vault that has already been unlocked with Unlock-SecretStore
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from secretmanagement.