Git Product home page Git Product logo

Comments (2)

m-schuetz avatar m-schuetz commented on August 22, 2024

Maybe it's because

v = static_cast<int32_t>(detail::sround((value - offset) / scale));

overflows for x and y but not z?
One problem could be that offset is always 0 and therefore we already lose quite a bit of the integer range.
Offset should probably be the min value of the bounding box or something like that.
I've only initialized the bounding box in https://github.com/potree/PotreeConverter/blob/master/PotreeConverter/include/LASPointWriter.hpp
and was under the impression that it automatically initializes the offset but maybe that is not the case since one of the las files I've converted has a 0 0 0 offset.

A warning, or even better abortion, should occur if the integer range is not enough to hold all values for a given scale and bounding box extent.
And maybe a warning if scale is < 0.001 because hardly any 3d scanner has a sub mm accuracy. Besides, laz compression suffers from unnecessary low scale.

from potreeconverter.

chiccorusso avatar chiccorusso commented on August 22, 2024

Could be. X and Y values are around 900, while Z is between 0 and 12.

from potreeconverter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.