Git Product home page Git Product logo

Comments (9)

guidoiaquinti avatar guidoiaquinti commented on July 3, 2024

@tiina303 can you add more info about this? Which secret are we trying to create?

from charts-clickhouse.

tiina303 avatar tiina303 commented on July 3, 2024

@paolodamico has been working on this, not sure if there was an issue tracking it already?

from charts-clickhouse.

guidoiaquinti avatar guidoiaquinti commented on July 3, 2024

@hazzadous I'm inclined to close this as part of #286. What do you think?

from charts-clickhouse.

hazzadous avatar hazzadous commented on July 3, 2024

I think this is actually a different issue @guidoiaquinti , assuming that the other linked PR is relevant. i.e. the desire is to setup email via the app UI(?)

from charts-clickhouse.

guidoiaquinti avatar guidoiaquinti commented on July 3, 2024

Yes but I think it was to avoid passing email settings via env variables, right @tiina303 ?

If yes, this issue should be in posthog/posthog

from charts-clickhouse.

paolodamico avatar paolodamico commented on July 3, 2024

I already have a PR that accomplishes this almost ready to go. Just need to do some final cleanup.

from charts-clickhouse.

tiina303 avatar tiina303 commented on July 3, 2024

In order to not need to pass email via envs here we needed it to be in the app. Not sure if we should keep the email/pass env option in the chart - it would be nice to be able to put them there for folks who setup multiple instances via automation but having a password as raw text might not be what we want to be doing. Happy to leave this for @guidoiaquinti & @hazzadous to decide.

from charts-clickhouse.

hazzadous avatar hazzadous commented on July 3, 2024

@tiina303 it's great for reproducible environments, which is the reason I put in the fix. The fix I've put in is actually to make it such that we don't need to expose CI for deploy at least to these secrets, and rather provision a k8s secret separately

Having these passed as env vars to the app I think is ok, but maybe there's a better way?

from charts-clickhouse.

guidoiaquinti avatar guidoiaquinti commented on July 3, 2024

I also think we should keep the ability to configure email settings via ENV variables as it’s good for several use cases.

My main question is if:

Ability to set the email config in the PostHog app.

is something belonging to this repo or not? My take is that it doesn’t as the solution described in this ticket is a PostHog app feature. In that case, we should simply close this issue.

from charts-clickhouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.