Git Product home page Git Product logo

Comments (3)

jeongyw12382 avatar jeongyw12382 commented on July 17, 2024

Thanks for your questions.
We'll double check your questions here and soon give you the reply.

from scnerf.

jeongyw12382 avatar jeongyw12382 commented on July 17, 2024

An update for this issue.

  1. We have normalized the coordinate of each pixel to [-1, 1] when applying radial distortions. Using f instead of c could also enhance the camera model. However, we expect changing the radial parameters could somewhat show similar behaviors. This setups were fine for our experiments. (+p' is the pixel coordinate after distortions have been applied)
    2, 3, 4. You are right. We will update the arXiv preprint soon. Fortunately, the pointed parts do not cause errors in our code or performance. Thanks for your suggestion.

from scnerf.

emjay73 avatar emjay73 commented on July 17, 2024

About Q1.
I thought the purpose of the eq5 is to convert pixel coordinates to normalized coordinate(z=1) as other distortion model does, but what you actually intended was to make pixel coordinates range from -1 to 1 right?
And if p' is distorted pixel coordinates, then the ray direction in eq 8 is a distorted ray direction?
I expected p' to be undistorted pixel coordinates so it's a bit confusing.

About Q2,3,4
Thank you for your confirmation. You cleared things up.

from scnerf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.