Git Product home page Git Product logo

Comments (4)

Porges avatar Porges commented on June 12, 2024

8c6e0c7 adds the isemail test-suite.

Another thing to think about: I should be testing the canonicalized versions of email addresses to ensure the normal form is as expected. (The isemail suite does not do this.)

from email-validate-hs.

Porges avatar Porges commented on June 12, 2024

Idea: use DataKinds for the options type that controls what to allow in the email address.

This way we have type EmailAddress = EmailAddress' SaneParseOptions and you can't accidentally mix email addresses parsed with different levels of flexibility.

Also: add a RestrictedEmailAddress for "Emails as they supported by most major providers".

Edit: didn't use DataKinds because that forces it onto the consumer. Instead we have a typeclass ParseOptions which supplies the configuration. This provides the extra safety without any extra burden on consumers.

from email-validate-hs.

MichelBoucey avatar MichelBoucey commented on June 12, 2024

@Porges Don't you know my IPv6Addr package? It should give all you need about IPv6 addresses. If not, feel free to contact me.

from email-validate-hs.

Porges avatar Porges commented on June 12, 2024

@MichelBoucey I didn't come across it when I was looking. It looks like it could be useful. I'll stick with ip for now until I get everything working and then have a better look.

One thing that might be required is: in order to pass the test-suite, in some situations I have to be able to parse IPv4-only addresses and not accept IPv6 ones. I'm not sure if this is possible with your current API (except if I parse and then check the result to see if it is IPv4-compatible).

from email-validate-hs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.