UnicodeDecodeError: 'ascii' codec can't decode byte about crackmapexec HOT 15 CLOSED

@maycon Hi, This is a bug in the impacket library will pass this along to the dev. Thanks

from crackmapexec.

Pinging @asolino, looks like a unicode bug in secretsdump.py here https://github.com/CoreSecurity/impacket/blob/master/examples/secretsdump.py#L1967.

from crackmapexec.

@byt3bl33d3r
Hmm.. I can't spot it.. can you?
Btw, there are two getBootKey methods. One is RemoteOperations.getBootKey() and the other one DumpSecrets.getBootKey(). This last one is used if you're reading the registry hives locally (as explained here).

I think you pointed out the wrong one.

from crackmapexec.

@asolino oops , yeah meant to point to RemoteOperations.getBootKey()

from crackmapexec.

I can't get to spot an encoding error there.. do you?

@maycon can you tell us:

1. Operating System (version and language) you're launching crackmapexec.py from?
2. Operating System (version and language) of the target system?
3. Is both impacket and crackmapexec running latest version?

from crackmapexec.

the exact line where the exception occurs is here https://github.com/CoreSecurity/impacket/blob/master/examples/secretsdump.py#L606

from crackmapexec.

@byt3bl33d3r yeah I saw that. But still don't understand why that would trigger an encoding error. Can you reproduce this issue?

@maycon any chance you add a

print repr(bootKey) 

before this for loop in crackmapexec.py at line 932?

and send us the output.

from crackmapexec.

@asolino holdon, think this might be my fault, will push a fix in a sec to see if it helps

from crackmapexec.

@byt3bl33d3r what do you think is it?

from crackmapexec.

@maycon Do a git pull and see if that helps.

@asolino just guessing, but I added

from __future__ import unicode_literals

so all strings are now unicode by default in CrackMapExec, there are a lot of variables initialized with an empty string like bootKey = '' which are now unicode strings so when it hits line 933 it might be having issues when appending to the string e.g.self.__bootKey += bootKey[transforms[i]]

from crackmapexec.

@byt3bl33d3r ohhh.. that is quite a change mate!. That could be it indeed.

from crackmapexec.

yeah looking back it wasn't a smart idea, was just fed up with dealing with unicode issues.

from crackmapexec.

@byt3bl33d3r I feel your pain.. Unicode ain't easy.

from crackmapexec.

@byt3bl33d3r, unicode pains will never end :(

from crackmapexec.

@maycon the new version should resolve at least some issues related to unicode

from crackmapexec.