gen_version.sh: echo need -e to support \n about omxplayer HOT 8 CLOSED

It seems to be doing the right think on my Ubuntu build machine.
Are you seeing the '\n' characters in version.h?
What platform are you building it on?

$ cat version.h
#ifndef __VERSION_H__
#define __VERSION_H__

#define VERSION_DATE "Mon, 29 Jul 2013 12:40:17 +0100"
#define VERSION_HASH "efd1049"
#define VERSION_BRANCH "master"
#define VERSION_REPO "[email protected]:popcornmix/omxplayer.git"

#endif

@skgsergio - any comments?

from omxplayer.

Yeah the '\n's are echoed to version.h as they are.

I'm using Arch. Ubuntu must have an alias set up by default for
echo -e....

from omxplayer.

It seems that Ubuntu's default shell Dash doesn't
support -e, but instead does it by default.
One way to fox this is to use full path to the
echo implementation provided by coreutils
/bin/echo or printf command (same syntax as in c)

from omxplayer.

Or use #!/bin/bash in scripts that use bashisms...

from omxplayer.

I were traveling so I'm sorry I didn't reply sooner.

My script its working on Debian (and dereivated) because uses dash.
I'll convert it to bash as is more "standard" (I use ZSH :P) and I'll make a pull request.

from omxplayer.

I wonder if this is a more portable way of producing a blank line.

echo #define VERSION_H
echo

from omxplayer.

Devil's advocate question: is there any need for blank lines in a generated header file like that? There's so little to the generated file, lack of blank lines arguably won't even hurt readability.

from omxplayer.

There is no reason except me, anyway I've noticed things like ${ref#refs/heads/} or ${upstream%/$branch} are behave strange in non bash interpreters.

from omxplayer.