Video Rotation about omxplayer HOT 14 CLOSED

The reason is very simple, the OMXVideo.cpp file isn't identical ;)

In official version : https://github.com/popcornmix/omxplayer/blob/master/OMXVideo.cpp (After Line 632)
is different of XBMC Version https://github.com/xbmc/xbmc/blob/master/xbmc/cores/omxplayer/OMXVideo.cpp (Block line 646-660).

No tested but you can add in OMXVideo.cpp:

switch(hints.orientation)
{
case 90:
m_transform = OMX_DISPLAY_ROT90;
break;
case 180:
m_transform = OMX_DISPLAY_ROT180;
break;
case 270:
m_transform = OMX_DISPLAY_ROT270;
break;
default:
m_transform = OMX_DISPLAY_ROT0;
break;
}

and you insert the parameter in omxplayer.cpp

One question for popcornmix > It's possible to change m_transform on the fly and not only start of the video ??

See you later

from omxplayer.

I believe transform can be changed whilst running.

from omxplayer.

Hello,
After reflexion, i can propose you the solution :)

Add in OMXStreamInfo.h :
After Line 61 : int orientation; // orientation of the video in degress counter clockwise

Add in OMXStreamInfo.cpp :
After Line 66 : orientation = 0;

Replace in OMXVideo.cpp :
switch(0) => switch(hints.orientation)

Add in omxplayer.cpp :
in main function : const int orientation_opt = 0x400;
in struct option longopts[] = { :
{ "orientation", required_argument, NULL, orientation_opt },
After threshold_opt case : Add :
case orientation_opt:
m_orientation = atoi(optarg);
break;

Before : if(m_has_video && !m_player_video.Open(m_hints_video, ...
Add :
// insert orientation
m_hints_video.orientation = m_orientation;

AND PLAY AGAIN :) (--orientation n, n with 0 90 180 270)

Topic close ;)
@popcornmix > little commit ? with dbus-daemon ;)

from omxplayer.

@fcarlier > That's great news--Thanks for your efforts.
@popcornmix > It would be fantastic if this could be included in the mainline build.

from omxplayer.

@fcarlier
Can't we initialise orientation from ffmpeg? (and also optionally allow command line override). See:
https://github.com/xbmc/xbmc/blob/master/xbmc/cores/dvdplayer/DVDStreamInfo.cpp#L220

from omxplayer.

used ffmpeg ? why ? you prefer this :
https://github.com/xbmc/xbmc/blob/master/xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecFFmpeg.cpp#L385

from omxplayer.

I believe orientation is encoded in some files (e.g. mov files from iPhone).
I believe ffmpeg demuxer parses this information.
I believe OMXReader.cpp can be edited to fill in hint.orientation so these videos play correctly without a command line option.

from omxplayer.

Ok but in my case, i like so command line for parameter the display ! we can make both (detect stream or command line in option)

from omxplayer.

Yes, default to what ffmpeg says, but allow command line option to override it.

from omxplayer.

YES :) Detect orientation of stream and possible command line option to override ;)

See You Later

from omxplayer.

Please test latest commit:
f944de7

from omxplayer.

The test is OK for me ;)

from omxplayer.

Rotation on fly by 'r' key pressed
fcarlier@e2149a3

from omxplayer.

@fcarlier @popcornmix

The build is working well for me, and especially valuable is the auto-rotate via ffmpeg info. One sidenote is that it does seem to require the most recent Raspbian distribution. I ran into quite a few issues running the July distribution that all went away once I did an apt-get upgrade.

I'll leave it to you to close the issue.

from omxplayer.