Use ip address instead of canonical name for Console->Agent communication about glu HOT 4 CLOSED

The code : https://github.com/linkedin/glu/blob/master/agent/org.linkedin.glu.agent-server-impl/src/main/groovy/org/linkedin/glu/agent/server/AgentMain.groovy#L138 is where it is happening.

The name (the one you modified) has no effect and is actually supposed to be a nice name so that in the console you don't end with an ip address.

I could use this instead: http://www.kiwidoc.com/java/l/p/java/j2se/1.6/p/java.net/c/InetAddress#getHostAddress%28%29

Since I am not a network expert and I don'k know too much about how people configure their hostname vs dns, etc.. I am not entirely sure which one is going to be always the correct one (canonical host name ? vs host name ? vs ip address ?).

Probably the best solution is to leave it the way it is but provide a way to configure it like you can change the name. Would that work for you ?

Yan

from glu.

Yan, you should use the ip address as it is always routable, i.e. No need for a DNS resolution, if the address is physically reachable, you are all good. :)
Since the display name is, as you say, different from what is actually being used, that could be the canonical host name, but use the ip internally, that way it will be a lot safer. Or add a configuration to define if one want to use DNS canonical host names or IPs, with default being an IP.

Alex

from glu.

I will do this.

Yan

from glu.

Implemented with 1.7.0

from glu.