Comments (4)
The code : https://github.com/linkedin/glu/blob/master/agent/org.linkedin.glu.agent-server-impl/src/main/groovy/org/linkedin/glu/agent/server/AgentMain.groovy#L138 is where it is happening.
The name (the one you modified) has no effect and is actually supposed to be a nice name so that in the console you don't end with an ip address.
I could use this instead: http://www.kiwidoc.com/java/l/p/java/j2se/1.6/p/java.net/c/InetAddress#getHostAddress%28%29
Since I am not a network expert and I don'k know too much about how people configure their hostname vs dns, etc.. I am not entirely sure which one is going to be always the correct one (canonical host name ? vs host name ? vs ip address ?).
Probably the best solution is to leave it the way it is but provide a way to configure it like you can change the name. Would that work for you ?
Yan
from glu.
Yan, you should use the ip address as it is always routable, i.e. No need for a DNS resolution, if the address is physically reachable, you are all good. :)
Since the display name is, as you say, different from what is actually being used, that could be the canonical host name, but use the ip internally, that way it will be a lot safer. Or add a configuration to define if one want to use DNS canonical host names or IPs, with default being an IP.
Alex
from glu.
I will do this.
Yan
from glu.
Implemented with 1.7.0
from glu.
Related Issues (20)
- Add optional description to deployment
- Allow more "fields" than just model name like a url
- Download speed is slow on big files
- Handle "master" default dashboard
- Don't let command run forever if not intentional HOT 2
- Find a way to display full output/error when forked process fails HOT 1
- Tidy up UI (Part II)
- Make glu work with java 8 HOT 1
- setup-pre-510.sh broken in 5.6.0 HOT 4
- Exception when no credential provided at login HOT 1
- Support for Enterprise Auth HOT 2
- DbCurrentSystem access not synchronized properly HOT 2
- Migrate grails tests to JUnit4 style
- Feature request: add 'local time' in UI
- Feature request: System recovery on node failure HOT 2
- When uninstalling, the glu agent tries to remove the target of a symlink HOT 4
- AuditLog should not fail
- Field in glu script does not appear in the console HOT 1
- View Glu agent tags in the console dashboard
- systemFilter not effective on 'current' model API
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glu.