Closing connection prevent cleaning session shutdown about pomm-bundle HOT 8 CLOSED

In foundation/Session/Connection.php, after pg_close set Connection::handler to null probably fixed this warning.

I can make the PR if you are agree.

from pomm-bundle.

Ah ah, that's what I did in the close_session branch, but it still does not shutdown the session properly and when session::__destruct is called, connection is re-opened to deallocate prepared statements which does not exist in the new session.

from pomm-bundle.

I have set up a close_connection branch on Foundation with a new API to close sessions from a Pomm instance. Would you mind having a look at it ?

from pomm-bundle.

IMO, the session should use new connection, not the one used by pomm. The problem is that if there is an transaction error, all further statements will be ignored. and thus session save will also fail.

from pomm-bundle.

You mean merging the pomm_shutdown branch with the new Connection system 2 months ago did not fix the problem ?

from pomm-bundle.

@chanmix51 I don’t know. This is your issue, is it fix?

I can test, but I need the unit test to reproduce the bug.

from pomm-bundle.

Oh. 😊 I was looking for something different and found this one. When talking about session in this thread I didn't realize, that the the session refers to the pomm session and not the application session. I deeply apologize.

from pomm-bundle.

ouf :) don't mind, that's ok. @sanpii can we close this one ?

from pomm-bundle.