SVN Commit Message Includes BR Tags about bugzilla-vcs HOT 13 CLOSED

Well. That's certainly weird. Will look into it.

My perl & regex isn't great, but as a personal workaround, commenting out the 
line in Extension.pm in the _filter_br function appears to generate the right 
link:


sub _filter_br {
    my ($value) = @_;
    $value =~ s/\r//g;
    $value =~ s/\s+$//sg;
#    $value =~ s/\n/<br>/sg;
    return $value;
}

That change fixed the link for me (also using Bugzilla 4.1.1), but then it no 
longer displays newlines within the commit message.  Perhaps if you change the 
CSS for vcs_commit_message to use "white-space: pre", then the br filter would 
not be necessary.  For my own installation, as a temp fix I changed the before 
mentioned br filter to this:

sub _filter_br {
    my ($value) = @_;
    $value =~ s/\r//g;
    $value =~ s/\s+$//sg;
    $value = "<pre>$value</pre>";
#$value =~ s/\n/<br>/sg;
    return $value;
}

Also, in case this helps speed up your troubleshooting...  in 4.1.1 I guess it 
converts "bug ###" into a link.  The link it converts it to looks like this 
(without your br filter applied):

<a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - ............"
   href="show_bug.cgi?id=62">Bug 62</a>

That's why it is messing things up, with the link like it is, the br filter 
ends up inserting br tags in the middle of the <a ..> tag.  Hope that helps...

[deleted comment]

Oops my solution makes the commit message really long on long commit messages 
with no newlines.  Better solution:  use style of "white-space: pre-line" for 
style of the vcs_commit_message.

Here's a patch this fixes this issue, and also some other minor changes. It was 
tested against 4.4, and should work on 4.2 too. Not sure about 4.0 since I 
never used it.

if i used the patch in #6, do i still have to do the change in #3? 

> if i used the patch in #6, do i still have to do the change in #3? 

No. This part does the same thing.

- [% commit.message FILTER quoteUrls(bug) FILTER vcs_br %]
+ [% commit.message FILTER vcs_br FILTER quoteUrls(bug) %]

but i got TWO weird commits session as pic show. Or this is where the "tested 
against 4.4" is?
my system as below:
svn 1.6.11
bugzilla 4.4
VCS bugzilla extension 0.2
perl v5.10.1
Linux 2.6.32-220.el6.x86_64

Have you run checksetup since making the changes in comment #6 to have the 
templates regenerated?

problem solved.
the reason is i don't know how to use patch file. so, i just simply add '#' in 
the head of line which i want take off. but they are not really commented, so 
there are two commits sessions and a lot of '#' sign.

still thanks sgreen.

modified template/en/default/hook/bug/edit-after_custom_fields.html.tmpl
modified template/en/default/vcs/commits.html.tmpl
modified web/style.css
Committed revision 24.                                                         

Issue 20 has been merged into this issue.