Comments (6)
Implementing Serialize
/Deserialize
for Limit
/LimitType
(and RateLimits
?) should be enough. Users can already read/write an instance's rate limits directly, which provides the most flexibility. Chorus doesn't need to care whether the user wants to store it as json or ron or xml in a file per instance or for multiple instances in a single file or where that file is or if it's actually in a database instead etc.
from chorus.
Fair point! Another case of the simplest solution being the best haha
from chorus.
i dont think storing ratelimits on disk would be a good idea?
from chorus.
Elaborate? Storing the ratelimits is important if you want to accurately keep track of what your current rate limits are. If you restart the library/application and you do not have them saved anywhere, then it'll just reset to the normal, unchanged ratelimits, and you'd run into limits
from chorus.
which is fine, how are you gonna handle different ratelimit implementations?
or well, as in spacebar-server-ts, the "global" rate limits?
from chorus.
If you are referring to the GlobalRegister and GlobalMessage limits: We don't track those. We cannot even track those, AFAIK.
from chorus.
Related Issues (20)
- Edit Message
- Audit Log Reason Parameter
- Modify Guild Member Profile
- Better gateway error handling
- Feature lock `openssl` and `rustls`
- Voice State object has no id field on ddc HOT 1
- Make `Gateway` and `GatewayHandle` generic over `futures_util::Stream` and `Sink` types HOT 1
- `UrlBundle` from`.well-known`
- Automatically check whether `Instance` is rate limited HOT 1
- Add `.well-known` as property for Instances
- Add `#![no_std]` for wasm compilation
- Add longer-lived gateway test
- API improvements for self-updating structs
- Potential future vulnerability in polyproto in Chorus HOT 2
- Changing the license of chorus HOT 11
- Custom message routing HOT 4
- Derive for `impl WebSocketEvent for ... {}`
- Re-evaluate `ChorusUser::shell` HOT 11
- Add actions checks for non-default feature configurations
- Implement gateway compression
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chorus.