Git Product home page Git Product logo

Comments (6)

SpecificProtagonist avatar SpecificProtagonist commented on June 18, 2024

Implementing Serialize/Deserialize for Limit/LimitType (and RateLimits?) should be enough. Users can already read/write an instance's rate limits directly, which provides the most flexibility. Chorus doesn't need to care whether the user wants to store it as json or ron or xml in a file per instance or for multiple instances in a single file or where that file is or if it's actually in a database instead etc.

from chorus.

bitfl0wer avatar bitfl0wer commented on June 18, 2024

Fair point! Another case of the simplest solution being the best haha

from chorus.

TheArcaneBrony avatar TheArcaneBrony commented on June 18, 2024

i dont think storing ratelimits on disk would be a good idea?

from chorus.

bitfl0wer avatar bitfl0wer commented on June 18, 2024

Elaborate? Storing the ratelimits is important if you want to accurately keep track of what your current rate limits are. If you restart the library/application and you do not have them saved anywhere, then it'll just reset to the normal, unchanged ratelimits, and you'd run into limits

from chorus.

TheArcaneBrony avatar TheArcaneBrony commented on June 18, 2024

which is fine, how are you gonna handle different ratelimit implementations?
or well, as in spacebar-server-ts, the "global" rate limits?

from chorus.

bitfl0wer avatar bitfl0wer commented on June 18, 2024

If you are referring to the GlobalRegister and GlobalMessage limits: We don't track those. We cannot even track those, AFAIK.

from chorus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.