Git Product home page Git Product logo

Comments (5)

jklein24 avatar jklein24 commented on July 26, 2024

FWIW, my proposal would be to remove the value property from iron-form-element altogether and have implementations use their own value type. Right now this would simply mean adding a value property to paper-input.

from paper-slider.

blasten avatar blasten commented on July 26, 2024

Thanks for reporting the issue. What do you think @morethanreal , @notwaldorf ?

from paper-slider.

notwaldorf avatar notwaldorf commented on July 26, 2024

Blerg. According to the forms spec, controls have a value, and it's a string, so the IronFormElementBehaviour is correct. Maybe paper-slider needs to cast it to a string?

/cc @cdata for thoughts too

from paper-slider.

jklein24 avatar jklein24 commented on July 26, 2024

I think that also means that we'll need to move IronFormElementBehavior to the end of the behaviors array to get the type right. @sjmiles to confirm. I know it may not matter to Polymer at runtime because it will just cast to a string, but would it matter if you were reflecting to an attribute or something? Either way, I know it matters to the compiler.

from paper-slider.

jklein24 avatar jklein24 commented on July 26, 2024

Sorry, just looked again and realized that IronFormElementBehavior is after IronRangeBehavior, but we assign a number to value, which is why I was getting a type error from the compiler like:

ERROR - assignment to property value of PaperSliderElement
found : number
required: string
this.value = this.min;

This means that we just need to make these assignments strings and we're good :-). I'll send a PR.

from paper-slider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.