Comments (5)
FWIW, my proposal would be to remove the value property from iron-form-element altogether and have implementations use their own value type. Right now this would simply mean adding a value property to paper-input.
from paper-slider.
Thanks for reporting the issue. What do you think @morethanreal , @notwaldorf ?
from paper-slider.
Blerg. According to the forms spec, controls have a value
, and it's a string, so the IronFormElementBehaviour
is correct. Maybe paper-slider
needs to cast it to a string?
/cc @cdata for thoughts too
from paper-slider.
I think that also means that we'll need to move IronFormElementBehavior to the end of the behaviors array to get the type right. @sjmiles to confirm. I know it may not matter to Polymer at runtime because it will just cast to a string, but would it matter if you were reflecting to an attribute or something? Either way, I know it matters to the compiler.
from paper-slider.
Sorry, just looked again and realized that IronFormElementBehavior is after IronRangeBehavior, but we assign a number to value, which is why I was getting a type error from the compiler like:
ERROR - assignment to property value of PaperSliderElement
found : number
required: string
this.value = this.min;
This means that we just need to make these assignments strings and we're good :-). I'll send a PR.
from paper-slider.
Related Issues (20)
- paper-slider only respects [dir=rtl] but not direction: ltr; in CSS nor nested [dir] HOT 3
- Can't change width of paper-slider element
- Unable to use paper-slider full width
- In #2.0-preview, the first drag of the thumb causes the thumb dissapear HOT 1
- Editable mode number only displaying 2 digits HOT 4
- a11y: macOS VoiceOver reads out a wrong command to use the slider HOT 1
- decrement and increment function not firing change event. HOT 1
- 'step' is not listed in available properties HOT 3
- Default dir='rtl' in Edge browser HOT 4
- logarithmic slider HOT 1
- Editable input does not fix number greater than max value
- ignoreBarTouch still prevents scrolling on Chrome for Android
- Feature request: Vertical orientation HOT 2
- Paper-slider is featured on one of our blogs
- Is it possible to style elements inside paper-slide ? HOT 1
- Replace `@polymer/iron-behaviors` with `@polymer/iron-range-behavior`
- v.2.0.8 is missing paper-slider.html HOT 3
- Trivial typo in the a11y test
- Typos in basic test
- pinLabel property needed to edit the content of the pin and a prop needed to keep the pin expanded
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paper-slider.