Active continues to be true when a route no longer matches the path about app-route HOT 5 CLOSED

The problem appears to be related to tail, which is not nulled-out or emptied out when it no longer corresponds to the current global path.

from app-route.

Ah yes, this: https://github.com/PolymerElements/carbon-route/blob/master/carbon-route.html#L176-L177

To clear or not to clear: that is the question.

from app-route.

P.S. I believe that this is the cause of the state leak that I referred to here. I suspect it goes like this: the objects are not cleared, so the queryParams changes - due to late-firing events from the YouTube element - bounce back up the tree via tail and cause the query string to go from empty to populated unexpectedly.

from app-route.

Interesting. I think this makes for a pretty good argument that the default behavior should be nulling out properties when a route no longer matches, and the case where you want to keep some information alive in an element should be the special case.

Making active work wouldn't be too hard I suspect, the tricky bit would be blocking queryParams in inactive routes while maintaining their state. I think you'd have to copy the queryParams object, which seems complex and inefficient.

@sjmiles

from app-route.

the default behavior should be nulling out properties when a route no longer matches

I think this makes a lot of sense for the first release. Maintaining state in inactive trees has a lot of subtle side-effects, especially when those trees may affect that state asynchronously.

I think you'd have to copy the queryParams object, which seems complex and inefficient

I agree, also you need to manually propagate changes (when appropriate) if you take this approach.

from app-route.