Git Product home page Git Product logo

Comments (6)

e111077 avatar e111077 commented on June 19, 2024

Just some quick thoughts:

{}

  • Less ways to check if empty and dont have to check for null and undefined
  • Our iron-query-params will always serve a {}
  • More-strict and easier to make future updates upon (it's harder to take away "features" over time)

null

  • fails fast
  • user has more freedom for changes
  • user will know whether query params has been initialized (e.g. null vs object)

from app-route.

cdata avatar cdata commented on June 19, 2024

That's a good shortlist of pros for each.

From a bike shed-y perspective, I like {}. Consider the following condition: el.set('route.queryParams.foo', 1). If 'route.queryParams' is an empty object, this will set foo to 1, and the (previously absent) query string in my browser location bar will reflect the change. However, if 'route.queryParams' is null, Polymer's data-binding system will silently disregard the change.

from app-route.

e111077 avatar e111077 commented on June 19, 2024

I personally lean {} for completely arbitrary reasons and the ones listed above.

from app-route.

cdata avatar cdata commented on June 19, 2024

Does this need more discussion? Have we landed on {}?

from app-route.

e111077 avatar e111077 commented on June 19, 2024

I think we did land on {} source

from app-route.

cdata avatar cdata commented on June 19, 2024

I'm gonna close this, since it seems resolved. We can re-open if it isn't 🐙

from app-route.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.