Git Product home page Git Product logo

Comments (4)

sjmiles avatar sjmiles commented on July 30, 2024

Fixed by a88671e

from polymer.

frankiefu avatar frankiefu commented on July 30, 2024

The issue is still happening in shim ShadowDOM.

from polymer.

sjmiles avatar sjmiles commented on July 30, 2024

Steve made issues/pending/shimShadowComponentEvents test case.

from polymer.

sjmiles avatar sjmiles commented on July 30, 2024

The problem arises because we are trying to walk into the shadow DOM from composed DOM.

Natively, a node exists only in one local DOM and the composed DOM is virtual (and can be ignored). Shim requires that a node exists only in composed DOM, so placeholders are used for other trees (Changelings).

Naively, node.changeling is used to locate the shadow DOM subtree where node is intended to exist. Unfortunately, multiple placeholders are used to implement projections and compositions, so node.changeling often refers to the wrong subtree.

I've attempted to solve this problem by:

(1) making sure that node.changeling is only set once (i.e. cache the initial position only)
(2) setting lightDOM.host
(3) coding the controller tree climber to use lightDOM.host as if it were parentNode

I may have missed a wrinkle, or there could be negative side-effects, which is why I wanted to document it here.

from polymer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.