Memory leaks in evpdm about jwt-cpp HOT 4 CLOSED

Thanks! Do you happen to have a pull request with the change by any chance?

from jwt-cpp.

I never did that but I took time to read how to do it. Pull request is done ;).

from jwt-cpp.

As a user of jwt-cpp, I was just passing by and checked out the PR. I can confirm it solves the leak on productive code. Also I'd suggest having following (or similar) change in the test code so the test output also stays clean at valgrind.

diff --git a/test/validators/validators_factory_test.cpp b/test/validators/validators_factory_test.cpp
index 87e6ac9..1cfa951 100644
--- a/test/validators/validators_factory_test.cpp
+++ b/test/validators/validators_factory_test.cpp
@@ -217,7 +217,7 @@ TEST(parse_test, accepts_multiple_types) {
""key1" : { "HS256" : { "secret" : "key1" } }, "
""key3" : { "HS512" : { "secret" : "key3" } } "
"} }";

• ASSERT_NO_THROW(MessageValidatorFactory::Build(json));

• ASSERT_NO_THROW(std::unique_ptr(MessageValidatorFactory::Build(json)));
  }

TEST(parse_test, rsa_not_in_pem_format) {

from jwt-cpp.

@goktan Would you mind sharing your patch as a pull request?

from jwt-cpp.