Undefined reference to `pok_ports_names_max_len' about pok HOT 6 CLOSED

Fixed the issue by adapting my code generator to define pok_ports_names_max_len variable.

from pok.

Hi Etienne,

Julien is right, there is a fix in my patch for #9 with an AWK one-liner to generate pok_port_names_max_len during compilation phase. Then this variable is extern in syscall.c and should be conditionally included only if we NEED_PORT.

I didn't touch your perl script and i think it might be the correct way to generate this variable, but if you do so, don't forget to remove my one-liner in the Makefile.

from pok.

Did you commit anything ? i don't see your changes.

from pok.

The fix was in my AADL to pok code generator (on another repository).

I saw the AWK part but it seems the problem was in my tool and did not appear in previous versions for a reason I do not understand. I also had a problem in conflicting definitions of strlen but I fixed it in my latest commit: it appeared yesterday and did not show up before.

Note/question: if the variable is defined in deployment.c, wouldn't the awk part lead to a redefinition of the variable after it is copied in sizes.c?

from pok.

I generated it in "sizes.c" as it is related to size questions :) If you also generate it in “deployment.c" obviously there will be a conflict.

Whatever your AADL generated does, this should not impact the compilation phase of the "generated" code, as the one-liner is called during final compilation phase.

I think you should take the decision on your own, whether or not doing it in the Makefile or in the perl configuration script (which i think is the best option as it is responsible for port names generation too).

By the way i didn't see the "#ifdef" around the "extern" definition of the "pok_port_names_max_len" in "syscall.c". Did you commit it ? It is mandatory, because if we do not make uses of POK ports in an example, there will be no definition of the variable outside "syscall.c".

from pok.

I just did the push

from pok.