newline in key value due to the citadel method about citadel HOT 6 CLOSED

its worth noting that i've made sure there are no newlines in the secret.pem file itself in S3.

from citadel.

Hmm, how are you verifying there is no newline in the file on S3? I don't see anything in the code that would risk a rogue character being added, just a straight HTTP GET call :-/

from citadel.

I just echo'ed a sample string into a new file and cat it.

What I upload to S3:

falcon@nest:~$ echo 'supersecret' > secret.pem
falcon@nest:~$ cat secret.pem
supersecret
falcon@nest:~$

Example of a file containing a newline:

falcon@nest:~$ echo -e "supersecret\n" > secret.pem
falcon@nest:~$ cat secret.pem
supersecret

falcon@nest:~$

I totally agree with you, code wise it doesn't look like any newlines are being added, but it seems to me that S3 itself is returning the new line for some reason.

Maybe i'm just nuts? lol i'll try to do some more digging shortly.

from citadel.

@domofactor try echo -n 'supersecret'

man echo
...

-n Do not print the trailing newline character

from citadel.

Closing this as not reproducible.

from citadel.

@coderanger I can reproduce this:

try to create a template like this:

template "/tmp/test" do
source "test.erb"
owner "root"
group "root"
mode 0660
variables({
:password => node['cookbook_teste]['password']
})
end

will generate this:

cat /tmp/test
password=P455word

if I create a file in my s3 bucket with this content:
P455word

and modify my recipe to use citadel like this:

template "/tmp/test_citadel" do
source "test.erb"
owner "root"
group "root"
mode 0660
variables({
:password => citadel['keys_secrets/password']
})
end

The result will be a /tmp/test_citadel with this content, including a breakline
P455word

diff between files /tmp/test /tmp/test_citadel

12:04:13 ip-10-0-54-20:~# diff /tmp/teste /tmp/teste_citadel
2a3

from citadel.