Warnings when using observable state in sheet presented from presentation state about swift-composable-architecture HOT 4 CLOSED

I was able to eliminate this warning by changing line 218 of PresentationModifier.swift:

- id: nil
+ id: store.id(state: \.self, action: \.self)

Could this cause any other issues? Looking at the history, when this code used to create a ViewStore there was a comment that has since been removed:

// NB: Introducing a `\.self` cache key here prevents dismissal from working.

It would be worth seeing if this is still the case.

from swift-composable-architecture.

Hi @lukeredpath, I think that change would be a good one to make. Can you PR it? You could also make the change on line 254, but notably it cannot be made to line 266. But that's OK because that version of PresentationStore is for when doing something like sheet(store:state:action:), which definitely does not play nicely with store caching due to the state and action transform functions.

from swift-composable-architecture.

@mbrandonw I'll open a PR - I'm not sure there is any value in adding it to line 254 either if you can't also give the destination store an ID (because there are no key/case key paths) because the destination is always going to be given a store that does not support caching anyway.

from swift-composable-architecture.

Feel free to leave it off.

from swift-composable-architecture.