[3.2.X] [3.3.1] Bug: Backup/Restore stores Rate options sometimes in a different order about moodle-mod_questionnaire HOT 5 OPEN

When creating the backup XML, you don't store the Rate options (the choices) in the proper order, you just assume they are stored in the correct order.

Source: backup_questionnaire_stepslib.php, line 179

        $questchoice->set_source_table('questionnaire_quest_choice', array('question_id' => backup::VAR_PARENTID));

Above should be more like

        $questchoice->set_source_table('questionnaire_quest_choice', array('question_id' => backup::VAR_PARENTID, "id"));

This way the backup saves the records of quest_choices in the correct order (id order, this is what you need at the moment).

Still I would advise to change the way the choice options are handled. You probably should never assume data is crowded together. Right now I can produce various errors by removing multiple choices (e.g. "1=XXX") and readding them later.

from moodle-mod_questionnaire.

After thinking about it, you should probably not sort by id in the backup. I recommend sorting by "value ASC". This way the values are in the correct order and the empty values (the "subquestions") are after that.

from moodle-mod_questionnaire.

I compared 3.2.4 to 3.3.1 . The above issue exists there, too (updated title accordingly)

from moodle-mod_questionnaire.

Bug still present in master.

from moodle-mod_questionnaire.

If the problem still is present, would you like a pull request?

from moodle-mod_questionnaire.