[3.2.X] [3.3.1] Bug: Feedback / Response Analysis - choosing values via choice id breaks the feedback about moodle-mod_questionnaire HOT 3 OPEN

Quick example fix: Use get_records with 1 limit:

// $firstcid[$qid] = $DB->get_record('questionnaire_quest_choice',
// array('question_id' => $qid), 'id', IGNORE_MULTIPLE);
$choiceRecord = $DB->get_records('questionnaire_quest_choice',
array('question_id' => $qid), "id",'id',0, 1);
if ($choiceRecord) {
$firstcid[$qid] = $choiceRecord[0];
}

from moodle-mod_questionnaire.

The above fix still presumes IDs are together. However, this may not be always the case when deleting options and then adding new options (in multiple steps).

So I propose this fix instead:

// $firstcid[$qid] = $DB->get_record('questionnaire_quest_choice',
// array('question_id' => $qid), 'id', IGNORE_MULTIPLE);
$allQuestionChoicesSql =
"SELECT * FROM {questionnaire_quest_choice}".
" WHERE question_id = :questionid".
" AND value <> ''".
" ORDER BY value ASC";
$params = array(
"questionid" => $qid
);
$questionChoices = $DB->get_records_sql($allQuestionChoicesSql, $params);
if (!$questionChoices) {
// This should never happen because it is a ranked question and therefore
// should have choices
continue;
}
$choiceIds = array_keys($questionChoices);
if (!isset($choiceIds[$rank])) {
// This would only happen if the choices were changed
// after responses were created
continue;
}
$value = $questionChoices[$choiceIds[$rank]];
// $firstcidid = $firstcid[$qid]->id;
// $cidvalue = $firstcidid + $rank;
// $sql = "SELECT * FROM {questionnaire_quest_choice} WHERE id = $cidvalue";

// if ($value = $DB->get_record_sql($sql)) {
if (isset($value)) {

This instead pulls all choice records for the question, sorts them by value ascending, and ignores the "possible answers". Then it uses the rank to determine the id of the choice used in the response and retrieves the corresponding choice.

from moodle-mod_questionnaire.

I compared 3.2.4 to 3.3.1 . The above issue exists there, too (updated title accordingly)

from moodle-mod_questionnaire.