some tests are broken about swagger-marshmallow-codegen HOT 7 CLOSED

https://travis-ci.org/podhmo/swagger-marshmallow-codegen/jobs/580537371

from swagger-marshmallow-codegen.

class A(Schema):
    nums = fields.List(fields.Integer(), validate=[ItemsRange(min=1, max=10), Unique()])

  File "swagger_marshmallow_codegen/tests/dst/00items.py", line 12, in A
    nums = fields.List(fields.Integer(), validate=[ItemsRange(min=1, max=10), Unique()])
  File "$HOME/venvs/my/swagger-marshmallow-codegen/swagger_marshmallow_codegen/validate.py", line 67, in __init__
    super().__init__(*args, **kwargs)
  File "$HOME/venvs/my/lib/python3.7/site-packages/marshmallow/validate.py", line 216, in __init__
    min_op=self.message_gte if self.min_inclusive else self.message_gt
KeyError: 'min'

from swagger-marshmallow-codegen.

min_inclusive and max_inclusive options are supported, officially?
And interface is changed?

from swagger-marshmallow-codegen.

hmm

marshmallow

• min_inclusive, max_inclusive
• default is True

openapi

• https://swagger.io/docs/specification/data-models/data-types/#Minimum%20and%20Maximum
• https://json-schema.org/understanding-json-schema/reference/numeric.html#range
• x < exclusiveMaximum
• x <= max (default)

so,

• jsonschema's minimum=10 as min=10 and inclusive_min=True
• jsonschema's exclusiveMinimum=10 as min=10 and inclusive_min=False

from swagger-marshmallow-codegen.

AdditonalProperty support is also broken.

from swagger_marshmallow_codegen.schema import AdditionalPropertiesSchema
from marshmallow import fields


class S(AdditionalPropertiesSchema):
    name = fields.String()


S().load({"name": "foo", "value": 10})

marshmallow.exceptions.ValidationError: {'value': ['Unknown field.']}

from swagger-marshmallow-codegen.

yeah, this hook is not worked.

since.

marshmallow-code/marshmallow@06aea4a

from swagger-marshmallow-codegen.

this is error. because using fields.Field()

from marshmallow import Schema, fields


class Product(Schema):
    product_id = fields.String()
    description = fields.String(description="Description of product.")


class ProductList(Schema):
    products = fields.List(fields.Field(Product))

use fields.NestedField.

from swagger-marshmallow-codegen.