Git Product home page Git Product logo

Comments (3)

obiltschnig avatar obiltschnig commented on April 28, 2024 1

EnvironmentImpl::nodeIdImpl() should be changed to also look for WiFi adapters if no Ethernet adapter was found.
And throw only if neither an Ethernet nor a WiFi adapter could be found.

from poco.

aleks-f avatar aleks-f commented on April 28, 2024

I think that this would work better if a SystemException was thrown when nodeIdImpl fails to set a value.

The documentation says if it can't find an ethernet adapter, but it should throw if it can not produce nodeId for any reason.

@andrewauclair please create a PR, and @matejk and myself will review

from poco.

andrewauclair avatar andrewauclair commented on April 28, 2024

Sounds good. One of my coworkers just happened to run into the Windows issue I mentioned. It looks like our Dell laptops only have wifi adapters and no ethernet adapters. The win32 nodeIdImpl only looks for ethernet adapters. Not sure what a good solution would be for this. Going to give it some thought.

from poco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.