Git Product home page Git Product logo

Comments (5)

cognvn avatar cognvn commented on July 4, 2024 1

I have same issue with monorepo + pnpm.overrides.
Here is the demo repo reproducing the bug: https://github.com/cognvn/demo-pmpm-issue
In this example, I use @pnpm/types in workspaces apps/web and packages/ui, then overrride "@pnpm/types": "file:./tarball/pnpm-types-10.0.0.tgz" in root workspace

This commit 04310be fix absolute path issue but lost relation to root workspace directory.
How about resolving it like link: protocol:

if (versionOverride.linkTarget && dir) {
deps[versionOverride.targetPkg.name] = `link:${normalizePath(
path.relative(dir, versionOverride.linkTarget)
)}`
continue
}
if (versionOverride.linkFileTarget) {
deps[
versionOverride.targetPkg.name
] = `file:${versionOverride.linkFileTarget}`
continue
}

from pnpm.

KSXGitHub avatar KSXGitHub commented on July 4, 2024 1

I have created #8055

from pnpm.

zkochan avatar zkochan commented on July 4, 2024

@KSXGitHub could this be related to the fix you did?

from pnpm.

KSXGitHub avatar KSXGitHub commented on July 4, 2024

@zkochan It's hard to say. I cannot reproduce the bug with pd.

Here's my package.json:

{
  "private": true,
  "dependencies": {
    "@pnpm/tabtab": "*"
  },
  "pnpm": {
    "overrides": {
      "@pnpm/tabtab": "file:../../programming/pnpm-tabtab"
    }
  }
}

from pnpm.

KSXGitHub avatar KSXGitHub commented on July 4, 2024

And I cannot reproduce the bug with the latest release of pnpm (v9.0.6) either

from pnpm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.