Add major tag `v2` about action-setup HOT 13 CLOSED

I came here to ask about this very thing -- I was confused as to why this GitHub Action suggests specifying an exact (X.Y.Z) version (currently pnpm/[email protected], with one exception*), when most GitHub Actions seem to suggest specifying only the major version, e.g. actions/checkout@v3.

Would it be difficult to start tagging releases with v2 in addition to e.g. v2.2.4? (Hopefully I'm correct in assuming that would resolve this issue)

Edit: upon further reflection, there is a certain brilliance to asking people to use pnpm/[email protected] -- that way, every time they look at their GitHub Actions and see it, they'll think: "Huh, I wonder if there's a new patch version of pnpm/action-setup... I'd better pop over and see, and while I'm at it, have a cup of tea and catch up with those wonderful folks that maintain it. Oh, and I might as well see if I can contribute in some way, I'll take a look at the open Issues & PRs, why not! 🫖🙋💭"

*: While I was poking around, noticed one of the three was out of sync: #64

from action-setup.

What do you think about editing the examples to use pnpm/action-setup@v2?

/cc @zkochan

from action-setup.

@mrienstra I see. It seems @zkochan forgot to update v2 when he published v2.2.4. Anyway, v2 is up-to-date now.

from action-setup.

There's already a v2 branch.

from action-setup.

I see, thanks @KSXGitHub! However, as a user it would be great to have a "stable" major tag which is only updated when there is a new release. As it is done with the checkout action, for example.

from action-setup.

We don't frequently release new versions, so I don't really see the point.

from action-setup.

Just a stupid question: I'm using "pnpm/action-setup@v2" and that means I'm not using the latest one? :O

from action-setup.

@pitgrap You are using the latest one.

from action-setup.

@KSXGitHub, I think v2 is currently even with v2.2.3, so slight behind v2.2.4:

• v2...v2.2.4
• v2...v2.2.3

(but maybe I'm missing something)

from action-setup.

There are two parts to this issue:

1. v2 should be kept current: it sounds like this is the intention and generally the case, so it seems like that part of this issue has been resolved for now.
2. Changing README to show pnpm/action-setup@v2 (drop minor & patch version numbers): where did we land on this? Personally, I think it would reduce confusion. But if the official word is "not changing at this time", then I think this issue can be closed.

from action-setup.

@mrienstra I don't object your second point.

from action-setup.

Optimistically opened a PR. :)

from action-setup.

Thank you, guys!

from action-setup.