feature request: built-in pnpm modules cache manager about action-setup HOT 5 CLOSED

note, action setup-node has added pnpm caching too https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

and documents using this action to install pnpm

from action-setup.

I have no objection, but I'm busy right now, so I will accept pull requests.

from action-setup.

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/runner-images#2279

This action or a run step npm i -g pnpm work reasonably fast and are flexible for users so i'm not sure there is a lot of demand/support for a builtin version

from action-setup.

Should we close this issue considering setup-node is giving support to it?

@dominikg do you think it would have sense to ask for pnpm to be included by default in steup-node as it does with npm and yarn ?

from action-setup.

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/virtual-environments#2279

Yep, I was thinking of using the same approach as yarn (I didn't know about actions' virtual environment). Thanks for this input here @dominikg.

With this said, should we close this issue @septs @KSXGitHub ?

from action-setup.