How to localize Command Sets? about sp-dev-fx-extensions HOT 5 CLOSED

I understand. It began as a question regarding specific extension, so I filed it here. I'll refile it in the correct issues list.

from sp-dev-fx-extensions.

And there it is, for the sake of progeny: SharePoint/sp-dev-docs#922

from sp-dev-fx-extensions.

I dug a little deeper, and it seems localizing Command Sets in this manner is not yet implemented, or forgotten all about.

In a file named listview-host-assembly-[locale]_[hash].js the commandslist is loaded from the spfx extension manifest.

While the manifest file neatly contains our localized resources:

...the commands list is instantiated with the default property:

from sp-dev-fx-extensions.

So basically we're currently stuck with a workaround like this:

public onInit(): Promise<void> {
    Log.info(LOG_SOURCE, 'Initialized CommandSetTestCommandSet');

    this.context._commands.forEach((command) => {
      command.title = strings[command.id];
    });

    return Promise.resolve();
  }

...which would force us to name resource properties after our command id's (in this case COMMAND_1, COMMAND_2)

from sp-dev-fx-extensions.

thx Martin, since this is a potential bug in the SPFx, would suggest using Issues list in https://github.com/SharePoint/sp-dev-docs/issues. which is our main channel for getting these kinds of potential issues known... and is getting synced to VSO automatically. I'll close this from here but would suggest to re-open in the right location so it gets the needed attention. I do apologize for the additional work. We use the sp-dev-docs for generic input and other repositories would be good for sample-specific issues, but not really for reporting potential issues in the actual SPFx. Thx for the issue details advance.

from sp-dev-fx-extensions.