Comments (14)
@xach - I don't maintain cl-colors2. What is the specific problem cl-ansi-text introduced - do you have a test run you could link?
from cl-ansi-text.
It's nothing directly to do with cl-ansi-text. The real problem is that cl-colors2's package name conflicts with the existing cl-colors, and some common dependency graphs now include both cl-colors and cl-colors2. For example, a number of projects' test systems depend on prove, and the projects also use the original cl-colors. When the system is loaded, both cl-colors and cl-colors2 load, causing a conflict.
Prove's dependence on cl-colors2 comes via cl-ansi-text.
I've proposed to cl-colors2 that it rename its package and the systems that require it be updated to use the new name. We'll see how that goes!
from cl-ansi-text.
@xach how much pain is this causing the broader ecosystem right now? If it's sufficiently painful, I can back out the cl-color2 change provisionally, and then we can restart work from there.
from cl-ansi-text.
Moderate pain. Some test systems are broken. It's early in the release cycle. I think it's better to fix the root cause in cl-colors2 at the moment. Time may change my priorities...
from cl-ansi-text.
OK. Looks like Cage has worked on addressing it - - https://notabug.org/cage/cl-colors2/issues/1
give me a heads up if you need me to apply a change. I have no desire to cause pain to ripple out.
from cl-ansi-text.
I should also note that Prove is apparently somewhat deprecated in favor of Rove - https://github.com/fukamachi/rove
from cl-ansi-text.
Ok, cl-colors2 now has the package cl-colors2
and not cl-colors
. Could you update the usage of cl-colors2 accordingly?
from cl-ansi-text.
@xach - sure thing.
from cl-ansi-text.
The branch fixes everything for me.
from cl-ansi-text.
Oh, and it would be great if it was merged to master.
from cl-ansi-text.
@xach - just to confirm - you mean the PR at #11 ? FWIW it doesn't work out of the gate in the CI system, since cl-color2's CL-COLORS2 package rename hasn't been pushed to the latest Quicklisp.
Do you plan to release both at the same time? If so, I'll happily merge to master.
from cl-ansi-text.
I'll release both at the same time.
from cl-ansi-text.
@xach - you're good to go on my end. Please advise if further issues arise!
from cl-ansi-text.
thank you @pnathan for cleaning this up --- I could not predict these issues and I feel sorry. thank you for your work @xach too.
from cl-ansi-text.
Related Issues (9)
- CI Broken on CMUCL HOT 3
- hex representation does not work. HOT 1
- Feature Request: ansi2html
- 4 bit bold/bright color variants
- Add cl-test-grid support
- Add "tty-p" command to allow analysis HOT 3
- Introduce style-sheets and some other stuff HOT 3
- CCL: No MAKE-LOAD-FORM method is defined for #S(CL-COLORS:RGB :RED 38/51 :GREEN 38/51 :BLUE 38/51) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cl-ansi-text.