Git Product home page Git Product logo

Comments (6)

yangx-jy avatar yangx-jy commented on July 16, 2024

Hi @grom72

How about the following APIs:

struct rpma_mr_local;
int rpma_mr_get_size(struct rpma_mr_local *mr, size_t *size);
int rpma_mr_get_mm_ptr(struct rpma_mr_local *mr, void **mm_ptr);

Best Regards,
Xiao Yang

from rpma.

grom72 avatar grom72 commented on July 16, 2024

API looks ok, I only suggest removing mm_ part from names.

from rpma.

yangx-jy avatar yangx-jy commented on July 16, 2024

API looks ok, I only suggest removing mm_ part from names.

Hi @grom72

Thanks for your comment.
I agree on removing 'mm_' part because it becomes simpler and clearer.

I will wait @janekmi @ldorau to review the PR.

Best Regards,
Xiao Yang

from rpma.

janekmi avatar janekmi commented on July 16, 2024

It looks good. Thank you @yangx-jy for this effort!

from rpma.

janekmi avatar janekmi commented on July 16, 2024

Ref: #925

from rpma.

yangx-jy avatar yangx-jy commented on July 16, 2024

Ref: #925

Hi @janekmi @ldorau

Ping.

Best Regards,
Xiao Yang

from rpma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.