Git Product home page Git Product logo

Comments (6)

jmlich avatar jmlich commented on September 5, 2024

I am not very happy with code quality, but it does the job and covers my needs. Feel free to reject pull request without any explanation. (-;

from bbb-render.

Zorlin avatar Zorlin commented on September 5, 2024

Looks alright to me, but I'm not exactly qualified to say so. :) Thanks for the contribution!

I'll let James have a look, but hopefully we'll merge this (possibly with changes).

(EDIT: I accidentally commented on the issue, not on the pull request. Please keep that in mind)

from bbb-render.

jhenstridge avatar jhenstridge commented on September 5, 2024

This seems like a reasonable feature. We used to prepend a short video intro to PLUG videos with our old production work flow, but I never got round to doing something similar for bbb-render. I'll try to make some time to look through PR #4 soon.

One nice thing about GES is that it probably doesn't matter whether the title cards are videos or static images.

from bbb-render.

jhenstridge avatar jhenstridge commented on September 5, 2024

I've merged PR #4 the change with a few modifications:

  1. the command line arguments are now --opening-credits and --closing-credits, and you will need to pass the option multiple times to set multiple credits. The nargs='+' mode interfered with parsing of positional arguments.
  2. If the credits file is a video rather than still image, it will default to the video's length. Using a video for the credits means you also get sound. I've kept the 3 second default for image credits.
  3. You can override the duration by passing FILENAME:DURATION as the option value, setting a duration in seconds.

Thanks for the contribution!

from bbb-render.

jmlich avatar jmlich commented on September 5, 2024

That's great!
In meantime I processed recordings from our conference.
https://www.youtube.com/watch?v=xu-3CmRefvc&list=PLOEQDQruWfhyIkXKzxAkEurpVpeI_U-iz&index=48

I have prepared a set of bash scripts and svg templates to generate video specific into/outro credits. It might be usable for you as well.
https://github.com/jmlich/bbb-batch-render/

from bbb-render.

jhenstridge avatar jhenstridge commented on September 5, 2024

They look great. I'm glad these scripts helped you process your videos.

from bbb-render.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.