Comments (23)
the question is, why is documentation on the checkouts? and if anyway it has to stay there, it does at least not have to make jenkins run again, right? π€ so we can add an exception list on the function on mr.roboto
or even remove the hooks for mr.roboto on the documentation repo itself... either of the two will fix this problem
from buildout.coredev.
@ale-rt if you can review this: plone/mr.roboto#91 ππΎ
from buildout.coredev.
As mentioned elsewhere this can be mitigated by adding:
documentation = git ${remotes:plone}/documentation.git pushurl=${remotes:plone_push}/documentation.git egg=false branch=6-dev path=${buildout:docs-directory}
But probably removing this hook might help.
from buildout.coredev.
I will try to fix the sources right now and investigate more on this later CC @plone/testing-team
from buildout.coredev.
π€ I think is a mr.roboto feature, if a package that is listed in sources gets a new change but is not on checkouts, it adds it, so one can ensure that the new features that landed on a package get tested
from buildout.coredev.
We can add an exception list on that functionality (if it actually works as I mentioned, which my not even be true π )
from buildout.coredev.
I do not know why it was added or whether it should be preserved in some way.
I now have access to the plone/documentation
repo settings, too.
from buildout.coredev.
Also this is not urgent from my perspective or from that of the branch 6-dev
in Plone Docs. Take your time. I just don't want to keep breaking Jenkins builds!
from buildout.coredev.
Indeed, there is such a functionality: https://github.com/plone/mr.roboto/blob/70e08fcab664a8db4e0749b92c6acca62288d46d/src/mr.roboto/src/mr/roboto/subscriber.py#L473
from buildout.coredev.
@gforcada I think you got it right but in the sources.cfg the repo is defined as:
docs = git ${remotes:plone}/documentation.git pushurl=${remotes:plone_push}/documentation.git egg=false branch=6-dev path=${buildout:docs-directory}
In #769 I provide an alias for that.
Maybe we should just switch docs
to documentation
, but I am afraid of implications I cannot see right now
from buildout.coredev.
I think that somewhere here we could make some check that excludes the documentation repo: https://github.com/plone/mr.roboto/blob/70e08fcab664a8db4e0749b92c6acca62288d46d/src/mr.roboto/src/mr/roboto/subscriber.py#L459-L469
from buildout.coredev.
sure, why is it though that the documentation is checked alongside the code? π€
from buildout.coredev.
I have time to do that now, if somebody wants to join me on that, please ping me in discord
from buildout.coredev.
sure, why is it though that the documentation is checked alongside the code? thinking
Maybe it is needed for some other automation, IMO it is not that bad to have that in the sources.cfg
.
from buildout.coredev.
@gforcada, PR approved, in the meanwhile I removed the unwanted checkout to restore the build.
Also, #769 seems to be a workaround, but I will close it since plone/mr.roboto#91
fixes the root cause of the issue.
from buildout.coredev.
Deployed to production, can someone test if my fix does work? π
from buildout.coredev.
We have a few WIP PRs. I'll let you know whether I get another alert after we merge the next one.
from buildout.coredev.
@gforcada PR #1160 merged. π€
from buildout.coredev.
I think it worked. This file was not updated. https://github.com/plone/buildout.coredev/blob/6.0/checkouts.cfg Is that what y'all were expecting?
from buildout.coredev.
Not sure what to make of this email. Is it still a problem?
POSSIBLE CHECKOUT ERROR plone/documentation 6-dev
Repository: plone/documentation
Author: stevepiercy <[email protected]>
Plone Version: 6.0
This package is used by Plone coredev 6.0 branch,
but itβs not currently checked out so is not including
your change for testing.
If you were merging a pull request,
worry not mr.roboto took care of it already,
still double check checkouts.cfg:
https://github.com/plone/buildout.coredev/blob/6.0/checkouts.cfg
On the other hand, if you made a direct commit to a branch,
add the package to checkouts.cfg (above link) please.
Regards,
mr.roboto
from buildout.coredev.
That's a safe check to ensure that if something goes wrong you get a heads up about it
from buildout.coredev.
Sorry for being ignorant. I'm new to this repo.
I don't know what is "expected". How do I know what is "something goes wrong"?
from buildout.coredev.
i.e. regular Plone packages are expected to be in a certain buildout.coredev branch, if a package is not check out it might miss the new changes being tested
from buildout.coredev.
Related Issues (20)
- Jenkins node 4 has problem with Python 3.6 and locales HOT 8
- Pillow >= 8.0.0 required for running coredev on M1 Macs HOT 8
- Pin cffi to 1.14.4 in order to avoid build failures on Apple M1 HOT 4
- Question: next steps in dev-stack? HOT 1
- Branch 6.0: Issue with portal_form_controller HOT 3
- Change default branch to 6.0 HOT 1
- Plone 6 should use latest zope.component, needs some test fixes HOT 2
- buildout freezes because of http links HOT 8
- POSSIBLE CHECKOUT ERROR plone/documentation 6-dev HOT 2
- Github Action broken in Plone 5.2 on Windows
- MacOS: error installing MarkupSafe in GitHub Actions HOT 2
- gh-actions: Windows buildout fails on z3c.relationfield HOT 2
- setting CORS headers HOT 2
- Plone 6.0 on Python 3.11 HOT 7
- buildout.coredev docs need to be pulled into Plone 6 Documentation HOT 12
- Python 2.7 got removed from Github Actions / setup-python HOT 1
- Set 6.1 as default branch on GitHub HOT 2
- bin/robot script is created from the robotframework entrypoint and not from plone.app.robotframework
- Problems with MacOS on GitHub Actions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildout.coredev.